Re: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2015-12-08 Thread Valerie Peng
Hi Siba, Here are some nits: I think it's somewhat misleading to use the term JCE here as what you are testing here is just security provider loading. JCE is more about security providers supporting export-controlled services/algorithms. Since your provider is just an empty one, I don't think

Re: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2015-12-08 Thread Valerie Peng
Right, that'd be my expectation as well. Sounds like everything works. I will change to look at your latest webrev. Valerie On 12/8/2015 6:09 AM, Sibabrata Sahoo wrote: Hi Valerie, Here is the updated webrev: http://cr.openjdk.java.net/~ralexander/8130360/webrev.00/ Now the modular behavior f

RE: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2015-12-08 Thread Sibabrata Sahoo
Hi Valerie, Here is the updated webrev: http://cr.openjdk.java.net/~ralexander/8130360/webrev.00/ Now the modular behavior for the test works as per expectation through JAKE build with the following condition. If the provider jar is available under ModulePath then the "java.security" file sho

Re: Code Review Request, 8133070 Hot lock on BulkCipher.isAvailable

2015-12-08 Thread Xuelei Fan
Ping ... On 12/1/2015 8:49 PM, Xuelei Fan wrote: > Hi, > > Please review the fix for JDK-8133070: > >http://cr.openjdk.java.net/~xuelei/8133070/webrev.00/ > > In (Open)JDK 6, EC cipher suites get supported by Java. However, there > is no default EC provider in JDK 6 at that time. In order

Re: Code Review Request 8144566, Custom HostnameVerifier disables SNI extension

2015-12-08 Thread Xuelei Fan
Good catch! I copied the comment here: -- SocketFactory sslsf = SSLSocketFactory.getDefault(); SSLSocket ssls = (SSLSocket) sslsf.createSocket(); ssls.connect(new InetSocketAddress( "bugs.openjdk.java.net", 443), 0); ssls.startHandshake(); No SNI is sent