Re: RFR [9] 8144995: Move sun.misc.HexDumpEncoder to sun.security.util

2015-12-10 Thread Mandy Chung
> On Dec 10, 2015, at 7:56 AM, Chris Hegarty wrote: > > sun.misc.HexDumpEncoder is an internal private API that is used almost > exclusively by the security library code. It should be moved out of sun.misc > and into a package more appropriate to its use, sun.security.util. > > HexDumpEncoder e

Re: RFR: Remove @Deprecated annotation from java.security.acl and javax.security.cert packages

2015-12-10 Thread Mandy Chung
On 12/10/2015 01:18 PM, Sean Mullan wrote: On 12/10/2015 01:14 PM, Mandy Chung wrote: On Dec 10, 2015, at 7:53 AM, Sean Mullan wrote: Max asked me to add the com.sun.jarsigner package to this bug, which also has an unnecessary @Deprecated annotation. I also made a few tweaks to the depreca

Re: RFR: Remove @Deprecated annotation from java.security.acl and javax.security.cert packages

2015-12-10 Thread Sean Mullan
On 12/10/2015 01:14 PM, Mandy Chung wrote: On Dec 10, 2015, at 7:53 AM, Sean Mullan wrote: Max asked me to add the com.sun.jarsigner package to this bug, which also has an unnecessary @Deprecated annotation. I also made a few tweaks to the deprecation wording here and there, so a webrev is pr

Re: Code Review Request, 8141651 Deadlock in sun.security.ssl.SSLSocketImpl

2015-12-10 Thread Bradford Wetmore
Looks good. Brad On 12/9/2015 11:40 AM, Sean Mullan wrote: Fix looks good, interesting issue, though I wonder if there is a better locking scheme, but probably a question for another time. --Sean On 12/05/2015 07:03 PM, Xuelei Fan wrote: Hi, Please review the fix for JDK-8141651: ht

Re: RFR: Remove @Deprecated annotation from java.security.acl and javax.security.cert packages

2015-12-10 Thread Mandy Chung
> On Dec 10, 2015, at 7:53 AM, Sean Mullan wrote: > > Max asked me to add the com.sun.jarsigner package to this bug, which also has > an unnecessary @Deprecated annotation. I also made a few tweaks to the > deprecation wording here and there, so a webrev is probably easier to review > than di

Re: RFR [9] 8144995: Move sun.misc.HexDumpEncoder to sun.security.util

2015-12-10 Thread Paul Sandoz
Looks ok to me, Paul. > On 10 Dec 2015, at 16:56, Chris Hegarty wrote: > > sun.misc.HexDumpEncoder is an internal private API that is used almost > exclusively by the security library code. It should be moved out of sun.misc > and into a package more appropriate to its use, sun.security.util. >

RFR [9] 8144995: Move sun.misc.HexDumpEncoder to sun.security.util

2015-12-10 Thread Chris Hegarty
sun.misc.HexDumpEncoder is an internal private API that is used almost exclusively by the security library code. It should be moved out of sun.misc and into a package more appropriate to its use, sun.security.util. HexDumpEncoder extends CharacterEncoder, which is slated for later removal, so the

Re: RFR: Remove @Deprecated annotation from java.security.acl and javax.security.cert packages

2015-12-10 Thread Sean Mullan
On 12/09/2015 04:51 PM, Mandy Chung wrote: On Dec 9, 2015, at 1:43 PM, Sean Mullan wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8144784 The @Deprecated annotation on a package is a no-op in terms of affecting the set of deprecation warnings the compiler produces. This has been clari