Re: RFR [9] 7067728: Remove stopThread default java.policy

2016-01-14 Thread Mandy Chung
> On Jan 14, 2016, at 2:05 AM, Chris Hegarty wrote: > > The "stopThread” RuntimePermission is granted by default. The Thread.stop > methods have been deprecated for more than 15 years. It seems reasonable, > in a major release, to remove the default grant of

Re: RFR [9] 7067728: Remove stopThread default java.policy

2016-01-14 Thread Mandy Chung
> On Jan 14, 2016, at 9:19 AM, Chris Hegarty wrote: > >> There are existing tests whose grants this "stopThread” RuntimePermission >> that may not be needed for the test. The test policy likely copies that >> from the default system java.policy. We should update

Re: RFR [9] 7067728: Remove stopThread default java.policy

2016-01-14 Thread Chris Hegarty
On 14 Jan 2016, at 17:29, Mandy Chung wrote: > >> On Jan 14, 2016, at 9:19 AM, Chris Hegarty wrote: >> >>> There are existing tests whose grants this "stopThread” RuntimePermission >>> that may not be needed for the test. The test policy

Re: RFR [9] 7067728: Remove stopThread default java.policy

2016-01-14 Thread Alan Bateman
On 14/01/2016 10:05, Chris Hegarty wrote: The "stopThread” RuntimePermission is granted by default. The Thread.stop methods have been deprecated for more than 15 years. It seems reasonable, in a major release, to remove the default grant of stopThread. This looks okay to me, we should have

Re: RFR [9] 7067728: Remove stopThread default java.policy

2016-01-14 Thread Chris Hegarty
On 14 Jan 2016, at 10:37, David Holmes wrote: > Hi Chris, > > I would have expected some tests to need modifying here (or other places!). I haven’t seen any test failures resulting from this change ( not sure if that is a good or a bad thing! ). Though, there were

Re: RFR [9] 7067728: Remove stopThread default java.policy

2016-01-14 Thread David Holmes
Hi Chris, I would have expected some tests to need modifying here (or other places!). David On 14/01/2016 8:05 PM, Chris Hegarty wrote: The "stopThread” RuntimePermission is granted by default. The Thread.stop methods have been deprecated for more than 15 years. It seems reasonable, in a

Re: RFR [9] 7067728: Remove stopThread default java.policy

2016-01-14 Thread Sean Mullan
Looks good to me. --Sean On 01/14/2016 05:05 AM, Chris Hegarty wrote: The "stopThread” RuntimePermission is granted by default. The Thread.stop methods have been deprecated for more than 15 years. It seems reasonable, in a major release, to remove the default grant of stopThread. diff --git

Re: RFR [9] 7067728: Remove stopThread default java.policy

2016-01-14 Thread Chris Hegarty
On 14 Jan 2016, at 16:52, Mandy Chung wrote: >> On Jan 14, 2016, at 2:05 AM, Chris Hegarty wrote: >> >> The "stopThread” RuntimePermission is granted by default. The Thread.stop >> methods have been deprecated for more than 15 years. It seems

Re: [xs] RFR: 8146967: [TEST_BUG] javax/security/auth/SubjectDomainCombiner/Optimize.java should use 4-args ProtectionDomain constructor

2016-01-14 Thread Valerie Peng
The changes look fine. However, this fix should apply to all versions of JDKs. When running against newer versions of JDK, this test accidentally passes due to other SubjectDomainCombiner regression tests and went through a different code path. Thanks, Valerie On 1/13/2016 12:09 AM, Ivan