Re: Code Review Request 8149417 Use final restricted flag

2016-02-23 Thread Sean Mullan
On 02/17/2016 08:28 PM, Xuelei Fan wrote: Hi, A new test case was added. Please review the update: http://cr.openjdk.java.net/~xuelei/8149417/webrev.01/ This looks fine to me. --Sean

Re: JEP Review Request: SHA-3 Hash Algorithm

2016-02-23 Thread Sean Mullan
This looks good. One suggestion, in the Description section, I think we should state what the standard algorithm names are for the 4 new MessageDigest algorithms. It is sort of implied, but I think we should be more specific. Perhaps after the "These can be implemented ..." sentence, add: "Th

Re: JEP Review Request: SHA-3 Hash Algorithm

2016-02-23 Thread Michael StJohns
On 2/17/2016 7:49 PM, Valerie Peng wrote: Please review this drafted JEP for adding SHA-3 Hash Algorithm support to JDK 9: https://bugs.openjdk.java.net/browse/JDK-8064399 Thanks, Valerie This looks pretty good. However, I wouldn't throw PKCS11 to the side of the road. https://wiki.oasis