JDK 9 RFR of JDK-8151763; Use more informative format for problem list

2016-03-11 Thread joe darcy
Hello, As Jon Gibbons has noted off-list, the problem list entries can directly include the bug number associated with the test in question, enabling better reporting. This format should be used rather than the current convention of putting the bug number in a comment. Please review the webr

Re: [9] RFR: 8151734: Mark Unreachable.java and MaxRetries.java as intermittently failing

2016-03-11 Thread Wang Weijun
The change looks fine. Thanks Max > On Mar 12, 2016, at 6:07 AM, Artem Smotrakov > wrote: > > Hello, > > The following krb5 tests have been observed to intermittently fail: > > sun/security/krb5/auto/Unreachable.java > sun/security/krb5/auto/MaxRetries.java > > Please see the following bugs

[9] RFR: 8151734: Mark Unreachable.java and MaxRetries.java as intermittently failing

2016-03-11 Thread Artem Smotrakov
Hello, The following krb5 tests have been observed to intermittently fail: sun/security/krb5/auto/Unreachable.java sun/security/krb5/auto/MaxRetries.java Please see the following bugs for details: https://bugs.openjdk.java.net/browse/JDK-8087144 https://bugs.openjdk.java.net/browse/JDK-8015595

Re: RFR 8140422: Add mechanism to allow non default root CAs to be not subject to algorithm restrictions

2016-03-11 Thread Anthony Scarpino
I updated the webrev and added the build-dev list as there are two makefile changes. http://cr.openjdk.java.net/~ascarpino/8140422/webrev.01/ thanks Tony On 02/29/2016 08:55 AM, Anthony Scarpino wrote: I need a code review of this change: Currently CertPath algorithm restrictions allow or

Re: RFR [Update]: JDK-8132942: ServerHandshaker should not throw SSLHandshakeException when CertificateStatus constructor is called with invalid arguments

2016-03-11 Thread Xuelei Fan
Looks fine to me. Thanks! Xuelei On 3/11/2016 4:39 PM, Jamil Nimeh wrote: > Hello all, > > This updated webrev switches from holding the stapling parameters as > instance fields to local variables to the clientHello() routine where > they are used. > > Bug: https://bugs.openjdk.java.net/browse

Re: Code Review Request 8149017 Delayed provider selection broken in RSA client key exchange

2016-03-11 Thread Xuelei Fan
On 3/11/2016 6:03 PM, Jeroen Cranendonk wrote: > Hmm, it looks like it should solve the problem I originally reported, > so that's good :) Yes, it is a fix for your reported issue. Thank you! > If there's a testing Windows JRE/JDK somewhere I can test it here ;) > > It might be worth investigati

Re: Code Review Request 8149017 Delayed provider selection broken in RSA client key exchange

2016-03-11 Thread Jeroen Cranendonk
Hmm, it looks like it should solve the problem I originally reported, so that's good :) If there's a testing Windows JRE/JDK somewhere I can test it here ;) It might be worth investigating other calls to KeyUtil.isOracleJCEProvider, I think I remember this not being the only place where this issue

RFR [Update]: JDK-8132942: ServerHandshaker should not throw SSLHandshakeException when CertificateStatus constructor is called with invalid arguments

2016-03-11 Thread Jamil Nimeh
Hello all, This updated webrev switches from holding the stapling parameters as instance fields to local variables to the clientHello() routine where they are used. Bug: https://bugs.openjdk.java.net/browse/JDK-8132942 Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8132942/webrev.02/ --J