Looks fine to me except two minor comments:
test/java/security/testlibrary/SimpleOCSPServer.java
-
254 serverReady = false;
For safe, I may put line 215-254 into a try-final block.
test/javax/net/ssl/Stapling/HttpsUrlConnClient.java
-
301 // Wait
On 4/12/16 4:08 AM, Xuelei Fan wrote:
Looks fine to me except two minor comments:
test/java/security/testlibrary/SimpleOCSPServer.java
-
254 serverReady = false;
For safe, I may put line 215-254 into a try-final block.
Fixed this and uploaded correct webrev
http:
> http://cr.openjdk.java.net/~rhalade/8153829/webrev.01/
Looks fine to me. Thanks!
Xuelei
On 4/12/2016 10:53 PM, Rajan Halade wrote:
>
>
> On 4/12/16 4:08 AM, Xuelei Fan wrote:
>> Looks fine to me except two minor comments:
>>
>> test/java/security/testlibrary/SimpleOCSPServer.java
>>
On 04/11/2016 11:59 AM, Anthony Scarpino wrote:
I believe I have addressed all previous comments and some changes were
made to rename cacerts to jdkCA and how it works AnchorCertificates.java
http://cr.openjdk.java.net/~ascarpino/8140422/webrev.03/
* CertConstraintParameters
31 * This clas
Hi Xuelei,
Mostly look good, just some comments in line...
line 95-100, so essentially, we will use the built-in parameters as much
as possible and if none available, we will try to generate the
parameters for key sizes <= 1024, right? The current comment is a little
hard to parse. Maybe we
Looks fine to me.
Thanks,
Xuelei
On 4/11/2016 11:59 PM, Anthony Scarpino wrote:
> Ok.. I changed it to:
> {@code jdk.security.provider.preferred} {@link
> Security#getProperty(String) Security}
>
> I updated it at the same link if someone wants to double check my work
> http://cr.openjdk.java.ne
Hi Max,
I think it would be better to update Solaris.sh with same format of
other scripts, please check the latest changeset:
http://cr.openjdk.java.net/~amjiang/8153545/webrev.03/
JPRT run is completed and all 3 tests has been passed in all platforms (
except Login.sh is excluded from windows
