Good points! I made the update accordingly.
http://cr.openjdk.java.net/~xuelei/8072452/webrev.04/
Thanks,
Xuelei
On 4/15/2016 1:33 AM, Seán Coffey wrote:
> without sounding like a broken record(!), can I ask that new exceptions
> provide better information (where possible) ?
>
> com/sun/cry
Please provide your review of following patch to SpecTest.java test.
This test purpose shouldn't require generating extra key pair with
different public exponent value.
Bug: https://bugs.openjdk.java.net/browse/JDK-8137231
Webrev: http://cr.openjdk.java.net/~rhalade/8137231/webrev.00/
Thanks,
I have no more comments.
Thanks,
Valerie
On 4/14/2016 4:12 AM, Xuelei Fan wrote:
Thanks for the comments. Here is the new webrev:
http://cr.openjdk.java.net/~xuelei/8072452/webrev.03/
On 4/14/2016 7:25 AM, Valerie Peng wrote:
Here are some comments for the test changes:
- Not testing
Thanks for the comment, I have removed extra check.
http://cr.openjdk.java.net/~rhalade/8151834/webrev.01/
Thanks,
Rajan
On 4/14/16 12:51 PM, Wang Weijun wrote:
Looks good.
Btw, since there is already the @requires tag, I think lines 52-56 are no
longer needed.
Thanks
Max
在 2016年4月15日，03:
Looks good.
Btw, since there is already the @requires tag, I think lines 52-56 are no
longer needed.
Thanks
Max
> 在 2016年4月15日，03:44，Rajan Halade 写道：
>
> Hi Max,
>
> Please review this patch to fix SmallPrimeExponentP test. It now uses fixed
> seed value to generate keypair. I did several
Hi Max,
Please review this patch to fix SmallPrimeExponentP test. It now uses
fixed seed value to generate keypair. I did several rounds of testing on
different machines to make sure that primes 63/65 are generated in fixed
number of iterations. Other updates to test are done to include detail
without sounding like a broken record(!), can I ask that new exceptions
provide better information (where possible) ?
com/sun/crypto/provider/DHKeyPairGenerator.java
+throw new InvalidParameterException(
+"Keysize must be multiple of 64, and can only range " +
+
Thanks for the comments. Here is the new webrev:
http://cr.openjdk.java.net/~xuelei/8072452/webrev.03/
On 4/14/2016 7:25 AM, Valerie Peng wrote:
> Here are some comments for the test changes:
>
>
> - Not testing key size 768?
> - line 82, would be useful to indicate version here, e.g. NSS (
