RFR 8154523: SHA1PRNG output should change after reset

2016-05-02 Thread Wang Weijun
Hi All Please take a review at http://cr.openjdk.java.net/~weijun/8154523/webrev.00 Basically, a reset in SHA1PRNG should forget the internal state and cached output. Thanks Max

Re: RFR: 8155775: Re-examine naming of privileged methods to access System properties

2016-05-02 Thread Claes Redestad
On 2016-05-02 16:15, Sean Mullan wrote: This looks good. Thanks! * src/java.base/share/classes/jdk/Version.java This is not an issue in your changes, but the current javadoc for Version.current() says: 266 * @throws SecurityException 267 * If a security manager

Re: RFR: 8155775: Re-examine naming of privileged methods to access System properties

2016-05-02 Thread Sean Mullan
On 05/02/2016 10:15 AM, Sean Mullan wrote: This looks good. Just a couple of comments: * src/java.base/share/classes/java/util/TimeZone.java 698 props.setProperty("user.timezone", id); This will only change the local copy of the property. I think you want to keep the original code

Re: RFR: 8155775: Re-examine naming of privileged methods to access System properties

2016-05-02 Thread Sean Mullan
This looks good. Just a couple of comments: * src/java.base/share/classes/java/util/TimeZone.java 698 props.setProperty("user.timezone", id); This will only change the local copy of the property. I think you want to keep the original code which does a System.setProperty. *