Re: RFR JDK-8000415: Add support for SHA-3

2016-05-04 Thread Wang Weijun
Hi Valerie This is not exactly a code review. I noticed you've updated static void l2bBig(long[] in, int inOfs, byte[] out, int outOfs, int len) in ByteArrayAccess.java. I also updated it during the implementation of SHA-512/224 (a part of DRBG) because here len is 28 but the original

Re: [jdk9] RFR: 8154947: Send empty list of authorities in CertificateRequest, if server has too many of them

2016-05-04 Thread Ivan Gerasimov
Thank you Xuelei for looking into this! On 26.04.2016 17:33, Xuelei Fan wrote: jdk.tls.handleCertReqAuthoritesOverflow is a little bit long. jdk.tls.server.overFlowAuthorites? Yes, I agree. Changed to a shorter property name. May not need to define the "none" property value. Using enum for

Re: [jdk9] RFR: 8154947: Send empty list of authorities in CertificateRequest, if server has too many of them

2016-05-04 Thread Ivan Gerasimov
Thank you Seán for looking into this! On 26.04.2016 16:56, Seán Coffey wrote: Looks like a fair approach to solving this issue Ivan. A few comments from me : typo : authoririesOverflow --> authoritiesOverflow typo : handleAuthoritesOverflow --> handleAuthoritiesOverflow typo :