Re: Code Review Request, 8154344 sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java fails on solaris

2016-05-06 Thread Wang Weijun
Or can we put it into problem list for Solaris now? > 在 2016年5月7日，07:19，Xuelei Fan 写道： > > Yes. This is might be a platform crypto lib issue. I want to bring > back the testing at first, and open the test again after the issue get > fixed.

Re: Code Review Request, 8154344 sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java fails on solaris

2016-05-06 Thread Xuelei Fan
On 5/7/2016 1:17 AM, Michael StJohns wrote: > On 5/6/2016 10:40 AM, Xuelei Fan wrote: >> Hi, >> >> Please review this simple test failure fix: >> >> http://cr.openjdk.java.net/~xuelei/8154344/webrev.00/ >> >> The underlying crypto lib may generate DH private keys out of the normal >> expected

Review Request: 8150468: ClassCircularityError on error in security policy file

2016-05-06 Thread Sean Mullan
Please review this fix for https://bugs.openjdk.java.net/browse/JDK-8150468: http://cr.openjdk.java.net/~mullan/webrevs/8150468/webrev.00/ The fix is to record bad policy files as they are parsed and ignore them during any subsequent permission checks. Thanks, Sean

Re: [8u-dev] Request for Review + Request for Approval for Backport 8049171: Additional tests for jarsigner's warnings

2016-05-06 Thread Svetlana Nikandrova
Hello, I would be grateful if someone could find time to review this. I received few off-line notes and decided to rework this backport a little. Here is my new webrev: http://cr.openjdk.java.net/~snikandrova/8049171/webrev.01/

Re: Code Review Request, 8154344 sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java fails on solaris

2016-05-06 Thread Michael StJohns
On 5/6/2016 10:40 AM, Xuelei Fan wrote: Hi, Please review this simple test failure fix: http://cr.openjdk.java.net/~xuelei/8154344/webrev.00/ The underlying crypto lib may generate DH private keys out of the normal expected range. This fix removes the range checking for DH private keys.

Code Review Request, 8154344 sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java fails on solaris

2016-05-06 Thread Xuelei Fan
Hi, Please review this simple test failure fix: http://cr.openjdk.java.net/~xuelei/8154344/webrev.00/ The underlying crypto lib may generate DH private keys out of the normal expected range. This fix removes the range checking for DH private keys. Thanks, Xuelei