Re: RFR: 8155775: Re-examine naming of privileged methods to access System properties

2016-05-09 Thread Wang Weijun
I have a question related. There are some places in JDK that use doPrivileged to read "os.name" etc. This system property is in the default java.policy file > On May 2, 2016, at 10:15 PM, Sean Mullan wrote: > > This is not an issue in your changes, but the current javadoc for > Version.current

Re: Code Review Request, 8154344 sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java fails on solaris

2016-05-09 Thread Wang Weijun
> On May 10, 2016, at 7:58 AM, Xuelei Fan wrote: > > On 5/10/2016 12:16 AM, Michael StJohns wrote: >> You're going to hate me, but shouldn't this be checking the Provider >> rather than the OS when trying to determine which test to ignore? >> > It's more accurate to check the provider, too. >

Re: RFR: regex changes -- sun.security.util.Debug issue

2016-05-09 Thread Wang Weijun
Security-dev, If we can live with "engine=keystore" happily, why not just make the whole string lowercase and search for "permission=java.io.filepermission"? I don't think there are permission types or URL names that are only different in cases. Although file names are case-sensitive in Unix, I

Re: RFR: regex changes -- sun.security.util.Debug issue

2016-05-09 Thread Xueming Shen
Hi, While testing for the attached regex changes, a fatal vm init error was triggered for test case with -Djava.security.debug=xyz turned on, as showed in following stacktrace. It appears sun.security.util.Debug is being initialized even before the lambda is ready for use, and unfortunately

Re: Review Request: 8150468: ClassCircularityError on error in security policy file

2016-05-09 Thread Mandy Chung
> On May 6, 2016, at 11:43 AM, Sean Mullan wrote: > > Please review this fix for https://bugs.openjdk.java.net/browse/JDK-8150468: > >http://cr.openjdk.java.net/~mullan/webrevs/8150468/webrev.00/ > > The fix is to record bad policy files as they are parsed and ignore them > during any sub

Re: Review Request: 8150468: ClassCircularityError on error in security policy file

2016-05-09 Thread Xuelei Fan
Looks fine to me except a minor comment. PolicyParser.java = 1366 return i18nMessage != null ? i18nMessage : form.format(source); May be nice to set the i18nMessage if it is not set yet. Thanks, Xuelei On 5/7/2016 2:43 AM, Sean Mullan wrote: > Please review this fix for > https

Re: Code Review Request, 8154344 sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java fails on solaris

2016-05-09 Thread Xuelei Fan
On 5/10/2016 12:16 AM, Michael StJohns wrote: > You're going to hate me, but shouldn't this be checking the Provider > rather than the OS when trying to determine which test to ignore? > It's more accurate to check the provider, too. - if (!System.getProperty("os.name").equals("SunOS")) { + i

Re: Code Review Request, 8154344 sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java fails on solaris

2016-05-09 Thread Michael StJohns
You're going to hate me, but shouldn't this be checking the Provider rather than the OS when trying to determine which test to ignore? Mike On 5/9/2016 10:36 AM, Xuelei Fan wrote: Updated to ignore the test on Solaris only: http://cr.openjdk.java.net/~xuelei/8154344/webrev.01/ Thanks,

Re: Code Review Request, 8154344 sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java fails on solaris

2016-05-09 Thread Wang Weijun
This looks good. Thanks Max > 在 2016年5月9日,22:36,Xuelei Fan 写道: > > Updated to ignore the test on Solaris only: > >http://cr.openjdk.java.net/~xuelei/8154344/webrev.01/ > > Thanks, > Xuelei > >> On 5/8/2016 7:59 AM, Xuelei Fan wrote: >> I still want the rest part (public key checking) ge

Re: Code Review Request, 8154344 sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java fails on solaris

2016-05-09 Thread Xuelei Fan
Updated to ignore the test on Solaris only: http://cr.openjdk.java.net/~xuelei/8154344/webrev.01/ Thanks, Xuelei On 5/8/2016 7:59 AM, Xuelei Fan wrote: > I still want the rest part (public key checking) get executed and > noticed. I will keep track of the evaluation of the underlying platfo