Re: RFR: JDK-8156584: Initialization race in sun.security.x509.AlgorithmId.get

Pushed. Xuelei, would you like to do the paperwork for the follow-on jdk8 backport? On Fri, May 13, 2016 at 4:58 PM, Xuelei Fan wrote: > On 5/14/2016 3:50 AM, Martin Buchholz wrote: >> Hi Xuelei, >> >> The jdk9 version is still up in the air. I propose committing: >>

Re: RFR: 9: 8155049: New tests from 8144566 fail with "No expected Server Name Indication"

Looks fine to me. hostname.indexOf('.') == -1 May be more straightforward to use hostname.contains("."). Thanks, Xuelei On 5/14/2016 3:56 AM, Rajan Halade wrote: > Please provide your review of this one line fix. > > These tests fail on machine where non-FQDN hostname is returned. As per >

Re: RFR: JDK-8156584: Initialization race in sun.security.x509.AlgorithmId.get

On 5/14/2016 3:50 AM, Martin Buchholz wrote: > Hi Xuelei, > > The jdk9 version is still up in the air. I propose committing: > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/AlgorithmId-get-race/ > Looks fine to me. Thanks! Xuelei > On Thu, May 12, 2016 at 5:01 PM, Xuelei Fan

RFR: 9: 8155049: New tests from 8144566 fail with "No expected Server Name Indication"

Please provide your review of this one line fix. These tests fail on machine where non-FQDN hostname is returned. As per RFC for SNI extension, hostname needs to be fully qualified DNS hostname and same is asserted in JDK when it adds hostname to SNI extension. This fix skips test execution

Re: RFR: JDK-8156584: Initialization race in sun.security.x509.AlgorithmId.get

Hi Xuelei, The jdk9 version is still up in the air. I propose committing: http://cr.openjdk.java.net/~martin/webrevs/openjdk9/AlgorithmId-get-race/ On Thu, May 12, 2016 at 5:01 PM, Xuelei Fan wrote: > On 5/13/2016 3:00 AM, Martin Buchholz wrote: >> I have a new simpler

Re: RFR JDK-8000415: Add support for SHA-3

Sean, I have added the values to the exception message as u suggested. As for the test vectors, I already put them (some of them) in separate internal tests for SUN and OracleUcrypto provider respectively. PKCS11 provider is not yet updated with the SHA-3 support, when it does, it will has its

Re: RFR 8154005: Add algorithm constraint that specifies the restriction date

Hi Ivan, I added your comments.. I had thought usePattern() wouldn't reuse the entry, but apparently the description is not the way I read it. You comments are incorporated into the webrev.01 that I posted previously thanks Tony On 05/12/2016 04:13 PM, Ivan Gerasimov wrote: Hi Anthony!

Re: RFR JDK-8000415: Add support for SHA-3

Valerie, some comments on supportability of the new code. Some handling could be improved to contain context perhaps : sun/security/provider/SHA3.java +if (numOfPadding < 1) { +throw new ProviderException("Incorrect pad size"); Can we print the numOfPadding value ? +