On 05/17/2016 01:09 PM, Valerie Peng wrote:
Hi Tony,
Here are some comments/questions:
- make PreferredEntry class static? Are these fields accessed directly
by other classes? If not, then we can mark them private?
Yes they can be private and the class static.
- "alternateName" should be "a
Hi Tony,
Here are some comments/questions:
- make PreferredEntry class static? Are these fields accessed directly
by other classes? If not, then we can mark them private?
- "alternateName" should be "alternativeNames" now that it contains
multiple values?
- In the match method, ls it really ne
JDK still support version 1 cert. Developers may want to test version 1
support of their applications. I agree that version 1 should be fade out
although it is still actively used the practice, especially as self signed cert.
It may be something that we only want to consider for self-signed ce
Hi Xuelei,
Can you elaborate under what circumstances this is useful for testing?
X.509 v3 was first published in 1996, and v1 certificates should be
pretty much non-existent these days (although there are some root certs
that are still v1). v1 certificates do not support extensions. Adding
s
Hi Max,
Here is the updated webrev:
http://cr.openjdk.java.net/~ssahoo/8141039/webrev.03/
I misinterpreted your previous comment that the following change is only
applicable to getInstanceTest.java and not applicable to ApiTest.java.
The change includes,
- ApiTest.java moved to " java/security/
