Re: (9) RFR: JDK-8137255: sun/security/provider/NSASuiteB/TestDSAGenParameterSpec.java timeouts intermittently

2016-05-23 Thread John Jiang
Hi, On 2016/5/24 7:12, Valerie Peng wrote: Looks fine to me. Thanks! Do you have approximate info on how long it took? I am curious as to how long it takes for the 3072 case. I run this test 100 times in a loop, and got much different elapsed time for 3072 case: 2.316s ~ 160.616s. Best reg

Re: (9) RFR: JDK-8137255: sun/security/provider/NSASuiteB/TestDSAGenParameterSpec.java timeouts intermittently

2016-05-23 Thread Valerie Peng
Looks fine to me. Do you have approximate info on how long it took? I am curious as to how long it takes for the 3072 case. Thanks, Valerie On 5/22/2016 11:43 PM, John Jiang wrote: Hi, Please review the patch for sun/security/provider/NSASuiteB/TestDSAGenParameterSpec.java timeouts intermit

Re: RFR 8157308: DRBG serialization fix

2016-05-23 Thread Wang Weijun
Ping again. > 在 2016年5月19日,16:21,Wang Weijun 写道: > > Please take a review at > > http://cr.openjdk.java.net/~weijun/8157308/webrev.00/ > > Now that DRBG does not save any internal state during serialization, all DRBG > implementations (HashDrbg, HmacDrbg, CtrDrbg) still extends SecureRando

Re: RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

2016-05-23 Thread Amanda Jiang
Hi Valerie , Rajan, Thanks for reviewing the webrev. I have updaed UnsupportedProvider.java to check NSAE for SUN and OracleUcrypto providers. Other tests has been updated by Rajan's comments as well. Please check the latest webrev and let me know if there are any other problems. http://

Re: RFR 8157526: 3KeyTDEA word left in DRBG after JDK-8156213

2016-05-23 Thread Bradford Wetmore
+1. Brad On 5/22/2016 6:29 PM, Xuelei Fan wrote: Looks fine to me. Xuelei On 5/23/2016 9:12 AM, Wang Weijun wrote: Hi All The removal of 3KeyTDEA in JDK-8156213 is not clean. This bug removes the "(112 bits for CTR_DRBG with 3KeyTDEA)" words in class spec of DrbgParameters.java. No webre

Re: RFR 8157544: Typo in CtrDrbg::toString

2016-05-23 Thread Bradford Wetmore
+1 Brad On 5/23/2016 1:53 AM, Xuelei Fan wrote: Looks fine to me. Xuelei On 5/23/2016 2:11 PM, Wang Weijun wrote: Once upon a time securerandom.drbg.config looks like "Hash_DRBG/SHA-256" and it was changed to "Hash_DRBG,SHA-256" because "Hash_DRBG/SHA-512/224" is ambiguous. DRBG::toString

Fwd: Re: RFE/RFC reproducible policies

2016-05-23 Thread Jiri Vanek
Hello security team! How do yo feel about lower suggested patch - reproducible policies? Thanx in advance, Bets regards from CZ J. Forwarded Message Subject: Re: RFE/RFC reproducible policies Date: Fri, 20 May 2016 11:04:25 +0200 From: Jiri Vanek To: Erik Joelsson , buil

[jdk9] RFR: 8080273: JCA Signature provider service loading bottlenecks

2016-05-23 Thread Ivan Gerasimov
Hello! It has been observed that under some circumstances a scalability bottleneck may be observed, when accessing the internal BlindingParameters structure in the sun.security.rsa.RSACore class. It is proposed to slightly reorganize the code around, to reduce the possible contention. Woul

Re: RFR 8154005: Add algorithm constraint that specifies the restriction date

2016-05-23 Thread Ivan Gerasimov
Thanks Anthony! On 13.05.2016 19:04, Anthony Scarpino wrote: Hi Ivan, I added your comments.. I had thought usePattern() wouldn't reuse the entry, but apparently the description is not the way I read it. You comments are incorporated into the webrev.01 that I posted previously Looks good

Re: RFR 8157544: Typo in CtrDrbg::toString

2016-05-23 Thread Xuelei Fan
Looks fine to me. Xuelei On 5/23/2016 2:11 PM, Wang Weijun wrote: > Once upon a time securerandom.drbg.config looks like "Hash_DRBG/SHA-256" and > it was changed to "Hash_DRBG,SHA-256" because "Hash_DRBG/SHA-512/224" is > ambiguous. > > DRBG::toString follows this style, but I forgot to update