RFR 8156471: test/sun/security/krb5/auto/TestHosts should not be modified in-place

2016-06-06 Thread Wang Weijun
Please review the change at http://cr.openjdk.java.net/~weijun/8156471/webrev.00/ Mark, I noticed a strange "irlga09" host name at the end of TestHosts [1]. Is it happened to be one of your test machines and you've added it with this test? I can remove it in this fix. Thanks Max [1] http:/

Re: RFR 8158442: SecureRandomParameters missing "@since 9"

2016-06-06 Thread Sean Mullan
Looks good. --Sean On 06/06/2016 02:22 AM, Wang Weijun wrote: I forgot to add "@since 9" in a new interface, please review this trivial change diff --git a/src/java.base/share/classes/java/security/SecureRandomParameters.java b/src/java.base/share/classes/java/security/SecureRandomParameters

Re: RFR 8062758: Update java/security/Security/ClassLoaderDeadlock/Deadlock2.sh with the removal of -Djava.ext.dirs

2016-06-06 Thread Sean Mullan
Looks fine to me. Also copying Mandy to see if she is ok with this. --Sean On 06/06/2016 01:40 AM, Bhanu Gopularam wrote: Hi all, Please review fix for following bug : Bug - https://bugs.openjdk.java.net/browse/JDK-8062758 Issue - Test java/security/Security/ClassLoaderDeadlock/Deadlock2.sh

Re: RFR 8158442: SecureRandomParameters missing "@since 9"

2016-06-06 Thread Bradford Wetmore
+1. All the classes in DrbgParameters are fine. ;) Brad On 6/5/2016 11:22 PM, Wang Weijun wrote: I forgot to add "@since 9" in a new interface, please review this trivial change diff --git a/src/java.base/share/classes/java/security/SecureRandomParameters.java b/src/java.base/share/classe

is it possible in openjdk 9 to advertise application protocol in the tls handshake?

2016-06-06 Thread Jon Berg
Hi, Given that you are acting as a server, it would be nice to be able to offer "http/1.1" as application. The purpose of this is to get chrome to do tls false start which require that the server "advertise" http/1.1 in ALPN or NPN. In the tls handshake. To do this it is just and integer and that

Re: [9] RFR: JDK-8158462: CipherTest should get rid of race condition

2016-06-06 Thread John Jiang
Hi, Please review this patch. Thanks! John Jiang On 2016/6/2 20:54, John Jiang wrote: Hi, Please review this updated webrev: http://cr.openjdk.java.net/~jjiang/8158462/webrev.01 I just updated the year in copyright notice. Best regards, John Jiang On 2016/6/2 14:11, John Jiang wrote: Hi,

Re: is it possible in openjdk 9 to advertise application protocol in the tls handshake?

2016-06-06 Thread Bradford Wetmore
JEP 244/ALPN, aka JDK-8144083/JDK-8051498 went into JDK 9 late last year. The API/design is at: https://bugs.openjdk.java.net/browse/JDK-8062848 In a nutshell, the client application sets the strings to send. The server application can parse the ClientHello if desired, and can do any SSL

Re: [9] RFR: JDK-8158462: CipherTest should get rid of race condition

2016-06-06 Thread Xuelei Fan
Hi John, If I understand correctly, you have the client side wait for a while so that the server can get run. This update may mitigate the race condition, but cannot get rid of the race condition. After the timeout, the server may still not ready. Did you catch a testing failure of the race con

RFR 8151836: keytool -importkeystore -help does not list option -destprotected

2016-06-06 Thread Wang Weijun
I forgot to list (enum Option) DESTPROTECTED as an option of (enum Command) IMPORTKEYSTORE. Here is the fix. Please take a review: diff --git a/src/java.base/share/classes/sun/security/tools/keytool/Main.java b/src/java.base/share/classes/sun/security/tools/keytool/Main.java --- a/src/java.base/

Re: RFR 8151836: keytool -importkeystore -help does not list option -destprotected

2016-06-06 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 6/7/2016 9:51 AM, Wang Weijun wrote: > I forgot to list (enum Option) DESTPROTECTED as an option of (enum Command) > IMPORTKEYSTORE. Here is the fix. Please take a review: > > diff --git a/src/java.base/share/classes/sun/security/tools/keytool/Main.java > b/

RFR 8158589: Possible integer overflow issues for DRBG

2016-06-06 Thread Wang Weijun
Hi All Please take a review at http://cr.openjdk.java.net/~weijun/8158589/webrev.00/ For the reseedCounter case, the default reseedInterval is Integer.MAX_VALUE and there is no integer bigger than it, therefore a new check reseedCounter < 0 is added. I had thought about making it long but c

Re: is it possible in openjdk 9 to advertise application protocol in the tls handshake?

2016-06-06 Thread Jon Berg
I have some basic TLS stuff running that seems OK, but I am not able to get ALPN working. I am using the binary version for linux ( https://jdk9.java.net/download/). * Looking at wireshark, firefox sends in "Client Hello" with ALPN protocol h2,spdy/3.1,http/1.1 * The "Server Hello" has no mention

RE: [9] RFR: 8157896: TestDSAGenParameterSpec.java test fails with timeout

2016-06-06 Thread Sibabrata Sahoo
Hi Xuelei, Please find the updated webrev: http://cr.openjdk.java.net/~ssahoo/8157896/webrev.01/ As suggested, I have increased the timeout for (3072 256) to 700. Thanks, Siba -Original Message- From: Xuelei Fan Sent: Saturday, June 04, 2016 6:02 AM To: Sibabrata Sahoo; Valerie Peng;