Great, this is what I want. Thanks.
> On Jun 17, 2016, at 8:28 AM, Xuelei Fan wrote:
>
> Maybe, you can have a look at:
> test/sun/security/pkcs11/Secmod/JksSetPrivateKey.java
>
> Xuelei
>
> On 6/16/2016 9:54 PM, Wang Weijun wrote:
>> Hi Guys
>>
>> I am working on a keytool -providername bu
> On Jun 17, 2016, at 10:31 AM, Xuelei Fan wrote:
>
> What did you mean "can a long field be a safe volatile?"
A long value cannot be updated atomically, and I am afraid that another thread
might only see half bits updated and the other half not.
--Max
>
> Xuelei
>
> On 6/17/2016 10:00 AM,
What did you mean "can a long field be a safe volatile?"
Xuelei
On 6/17/2016 10:00 AM, Wang Weijun wrote:
> Ping again.
>
>> On Jun 7, 2016, at 11:52 AM, Wang Weijun wrote:
>>
>> Hi All
>>
>> Please take a review at
>>
>> http://cr.openjdk.java.net/~weijun/8158589/webrev.00/
>>
>> For the res
Looks fine to me.
Xuelei
On 6/17/2016 10:00 AM, Wang Weijun wrote:
> Ping again.
>
>> On Jun 6, 2016, at 6:34 PM, Wang Weijun wrote:
>>
>> Please review the change at
>>
>> http://cr.openjdk.java.net/~weijun/8156471/webrev.00/
>>
>> Mark, I noticed a strange "irlga09" host name at the end of T
Ping again.
> On Jun 6, 2016, at 6:34 PM, Wang Weijun wrote:
>
> Please review the change at
>
> http://cr.openjdk.java.net/~weijun/8156471/webrev.00/
>
> Mark, I noticed a strange "irlga09" host name at the end of TestHosts [1]. Is
> it happened to be one of your test machines and you've ad
Ping again.
> On Jun 7, 2016, at 11:52 AM, Wang Weijun wrote:
>
> Hi All
>
> Please take a review at
>
> http://cr.openjdk.java.net/~weijun/8158589/webrev.00/
>
> For the reseedCounter case, the default reseedInterval is Integer.MAX_VALUE
> and there is no integer bigger than it, therefore
Maybe, you can have a look at:
test/sun/security/pkcs11/Secmod/JksSetPrivateKey.java
Xuelei
On 6/16/2016 9:54 PM, Wang Weijun wrote:
> Hi Guys
>
> I am working on a keytool -providername bug [1] and would like to write a
> test with a provider that does not allow a private key to be exported
On 06/16/2016 12:17 AM, Wang Weijun wrote:
Hi Sean
Please review a resource string change
diff --git
a/src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java
b/src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java
--- a/src/jdk.jartool/share/classes/sun/
> On Jun 16, 2016, at 9:47 PM, Wang Weijun wrote:
>
>
>> On Jun 16, 2016, at 5:17 PM, Xuelei Fan wrote:
>>
>> Maybe better to throw an exception so that the caller know that the
>> reply is not valid. Tolerate problems may become a problem in the future.
>
> In this case, I only remove dup
Hi Guys
I am working on a keytool -providername bug [1] and would like to write a test
with a provider that does not allow a private key to be exported (therefore not
usable by Signature in another provider). Do we already have one inside
jdk/test? Or is it possible to configure the SunPKCS11-N
> On Jun 16, 2016, at 5:17 PM, Xuelei Fan wrote:
>
> Maybe better to throw an exception so that the caller know that the
> reply is not valid. Tolerate problems may become a problem in the future.
In this case, I only remove duplicated certs. Nothing else is tolerated.
>
> If you want to tol
Maybe better to throw an exception so that the caller know that the
reply is not valid. Tolerate problems may become a problem in the future.
If you want to tolerate the duplicate cert in the chain, please add a
comment about the use of hash set. The purpose of the use of hash set
is not instinc
Please review the code change at
http://cr.openjdk.java.net/~weijun/6968542/webrev.01/
Thanks
Max
13 matches
Mail list logo
