Re: RFR: 8161303: Sample NIO Server README needs updating.

Looks fine to me. Nice catch! Thanks, Xuelei On 7/28/2016 8:39 AM, Bradford Wetmore wrote: > > A trivial update to the README to remove -source/-target 1.5 in the > sample code. > > https://bugs.openjdk.java.net/browse/JDK-8161303 > http://cr.openjdk.java.net/~wetmore/8161303/webrev.00 > > Th

Re: RFR: 8161527: NPE is thrown if exempt application is bundled with specific cryptoPerms

Looks fine to me. I like the update to use braces. Thanks, Xuelei On 7/28/2016 8:39 AM, Bradford Wetmore wrote: > > This bug has been around since JDK 5 and likely before. :( > > If you bundle a specific length cryptoPerms, calls to Cipher with an > illegal size key will NPE. The fix in Crypt

RFR: 8161527: NPE is thrown if exempt application is bundled with specific cryptoPerms

This bug has been around since JDK 5 and likely before. :( If you bundle a specific length cryptoPerms, calls to Cipher with an illegal size key will NPE. The fix in CryptoPermissions is almost exactly the same as what is in java.security.Permissions. I took the liberty of doing a little sy

RFR: 8161303: Sample NIO Server README needs updating.

A trivial update to the README to remove -source/-target 1.5 in the sample code. https://bugs.openjdk.java.net/browse/JDK-8161303 http://cr.openjdk.java.net/~wetmore/8161303/webrev.00 Thanks, Brad

Re: Code Review Request: JDK-8161506 : Deprecate pre-1.2 SecurityManager methods and fields with forRemoval=true

On 07/27/2016 12:45 PM, Coleen Phillimore wrote: This looks great. Thank you! Should we have another bug to actually remove the code and hotspot code for jdk10 Yes we should. We need to also do that for all of the other APIs that we have added forRemoval=true to for 9, so I was thinking abou

Re: Code Review Request: JDK-8161506 : Deprecate pre-1.2 SecurityManager methods and fields with forRemoval=true

This looks great. Thank you! Should we have another bug to actually remove the code and hotspot code for jdk10 and make it blocked by https://bugs.openjdk.java.net/browse/JDK-8162416? thanks, Coleen On 7/27/16 9:53 AM, Xuelei Fan wrote: Looks fine to me. Xuelei On 7/27/2016 9:02 PM, Sean

Re: Code Review Request: JDK-8161506 : Deprecate pre-1.2 SecurityManager methods and fields with forRemoval=true

Looks fine to me. Xuelei On 7/27/2016 9:02 PM, Sean Mullan wrote: > Please review this change to mark the pre-1.2 deprecated SecurityManager > methods (and 1 field) with forRemoval=true. These methods are no longer > necessary and are known to be error-prone and have been deprecated since > JDK 1

Code Review Request: JDK-8161506 : Deprecate pre-1.2 SecurityManager methods and fields with forRemoval=true

Please review this change to mark the pre-1.2 deprecated SecurityManager methods (and 1 field) with forRemoval=true. These methods are no longer necessary and are known to be error-prone and have been deprecated since JDK 1.2. The intention is to remove them in a subsequent release of Java SE.