Re: [9] RFR 8154113: java.security.AccessControlException: access denied ("java.security.SecurityPermission" "authProvider.SunMSCAPI")

2016-08-03 Thread Mandy Chung
A passing comment: The test can simply specify @modules jdk.crypto.mscapi and this test will only run when jdk.crypto.mscapi is present; in other words, line 45-48 are no longer needed. Mandy > On Aug 3, 2016, at 6:09 AM, Sean Mullan wrote: > > Hi Valerie, > > Can

Re: [9] RFR 8154113: java.security.AccessControlException: access denied ("java.security.SecurityPermission" "authProvider.SunMSCAPI")

2016-08-03 Thread Valerie Peng
Sure, webrev updated: http://cr.openjdk.java.net/~valeriep/8154113/webrev.01/ Thanks, Valerie On 8/3/2016 6:09 AM, Sean Mullan wrote: Hi Valerie, Can you also clean up the noaccess.policy and access.policy files and remove the permissions that are now granted to the jdk.crypto.mscapi

Re: [9] RFR 8154113: java.security.AccessControlException: access denied ("java.security.SecurityPermission" "authProvider.SunMSCAPI")

2016-08-03 Thread Sean Mullan
Hi Valerie, Can you also clean up the noaccess.policy and access.policy files and remove the permissions that are now granted to the jdk.crypto.mscapi module in default.policy? Also, in the test, I would use the java.security.policy== option instead of the policy option. The policy option

Re: Code Review Request JDK-8162362, Cannot enable previously default enabled cipher suites

2016-08-03 Thread Seán Coffey
looks good. Regards, Sean. On 03/08/16 10:23, Xuelei Fan wrote: New webrev: http://cr.openjdk.java.net/~xuelei/8162362/webrev.01/ On 8/3/2016 4:13 PM, Seán Coffey wrote: Hi Xuelei, Thanks for taking this one on. I think the approach looks good. Some minor comments .. Can we update bug

Re: Code Review Request JDK-8162362, Cannot enable previously default enabled cipher suites

2016-08-03 Thread Xuelei Fan
New webrev: http://cr.openjdk.java.net/~xuelei/8162362/webrev.01/ On 8/3/2016 4:13 PM, Seán Coffey wrote: > Hi Xuelei, > > Thanks for taking this one on. I think the approach looks good. Some > minor comments .. > > Can we update bug description to something like "Introduce system > property

Re: Code Review Request JDK-8162362, Cannot enable previously default enabled cipher suites

2016-08-03 Thread Seán Coffey
Hi Xuelei, Thanks for taking this one on. I think the approach looks good. Some minor comments .. Can we update bug description to something like "Introduce system property to control enabled ciphersuites" SSLContextImpl.java : typo : getCustomizedCipehrSuites --> getCustomizedCipherSuites