How about
this.prf = (passwdBytes.length == 0) ?
Mac.getInstance(prfAlgo, SunJCE.getInstance()) :
Mac.getInstance(prfAlgo);
Mac is only implemented in SunPKCS11 and SunJCE out-of-box, so this
saves an extra getInstance() call.
If a 3rd party provider is involved, I'm not sure it
Me too.
--Max
On 8/19/2016 23:11, Xuelei Fan wrote:
Looks fine to me.
Xuelei
On 8/19/2016 10:25 PM, Sean Mullan wrote:
Please review this docs-only fix to provide descriptions for the
jdk.security.auth and jdk.security.jgss modules:
> On Aug 16, 2016, at 10:17 AM, Alexandre (Shura) Iline
> wrote:
>
> Hi.
>
> Please review fixes related to module dependencies in a few jdk tests:
> http://cr.openjdk.java.net/~shurailine/8163126/webrev.00/index.html
Looks okay. I will sponsor this patch for you.
Mandy
Looks fine to me.
Thanks,
Valerie
On 8/19/2016 9:57 AM, Vincent Ryan wrote:
Please review this fix to PBE key derivation function which detects
when a non-empty password
is supplied to the SunPKCS11-Solaris JCE provider and fails over to
the SunJCE provider instead.
Thanks.
Bug: https://bugs.
Please review this fix to PBE key derivation function which detects when a
non-empty password
is supplied to the SunPKCS11-Solaris JCE provider and fails over to the SunJCE
provider instead.
Thanks.
Bug: https://bugs.openjdk.java.net/browse/JDK-8164494
Webrev: http://cr.openjdk.java.net/~vinnie/
On 8/18/2016 8:48 PM, Valerie Peng wrote:
I share your view on most things. It's just that the APIs are there
before the PKCS11 provider is added.
So, there are some history reason as to why things are as they are today.
Re-structuring the public classes are almost impossible considering
the
Looks fine to me.
Xuelei
On 8/19/2016 10:25 PM, Sean Mullan wrote:
Please review this docs-only fix to provide descriptions for the
jdk.security.auth and jdk.security.jgss modules:
diff -r 657a5b92e26e src/jdk.security.auth/share/classes/module-info.java
--- a/src/jdk.security.auth/share/class
Please review this docs-only fix to provide descriptions for the
jdk.security.auth and jdk.security.jgss modules:
diff -r 657a5b92e26e src/jdk.security.auth/share/classes/module-info.java
--- a/src/jdk.security.auth/share/classes/module-info.java Fri Aug 19
13:50:03 2016 +0200
+++ b/src/jdk.sec
OK.
Xuelei
On 8/19/2016 7:47 PM, Weijun Wang wrote:
On 8/19/2016 16:48, Xuelei Fan wrote:
Looks fine to me.
BTW, why not check the class name right after the object is created?
This is just a small enhancement to an existing test, and I don't want
to break the existing block. I added a com
On 8/19/2016 16:48, Xuelei Fan wrote:
Looks fine to me.
BTW, why not check the class name right after the object is created?
This is just a small enhancement to an existing test, and I don't want
to break the existing block. I added a comment there.
And I've enhanced the test a little to c
Looks fine to me.
BTW, why not check the class name right after the object is created?
Xuelei
On 8/19/2016 2:34 PM, Weijun Wang wrote:
Please review the code change at
http://cr.openjdk.java.net/~weijun/8164437/webrev.00
The updated test shows that with the jdk.security.jgss package, the
11 matches
Mail list logo
