Re: RFR: 8150530:Improve javax.crypto.BadPaddingException messages

2016-08-22 Thread Xuelei Fan
Minor comments: CipherCore.java --- "... could arise if a bad key or password is used during decryption." "password" may be confusing for some user cases. This could also happen if bad key used for encryption. I may just say "could arise if a bad key used." RSAPadding.java -

Re: RFR : 8162362: Introduce system property to control enabled ciphersuites

2016-08-22 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 8/21/2016 8:59 PM, Seán Coffey wrote: I'd like to backport this to jdk8u-dev. The new jdk.tls.client.cipherSuites and jdk.tls.server.cipherSuites system properties will allows users to control what ciphersuites are enabled on SSL Sockets/Engines. One extra ed

RFR: 8150530:Improve javax.crypto.BadPaddingException messages

2016-08-22 Thread Seán Coffey
Looking to improve some of the messages used in generation of BadPaddingException messages. The 'Given final block not properly padded' one in particular has caused confusion for some users in the past. JBS report : https://bugs.openjdk.java.net/browse/JDK-8150530 webrev : http://cr.openjdk.jav