Re: RFR 8157404: Unable to read certain PKCS12 keystores from SequenceInputStream

Hi Svetlana, DerValue class may be implicitly used in different areas (x509, SSL/TLS, keystores, maybe krb5, etc). Please make sure that tests from jdk_security pass. I'll leave the main review to someone who is more knowledgeable in this area, here are a couple of comments: - Please update

Re: RFR: 8061842: Package jurisdiction policy files as something other than JAR

http://cr.openjdk.java.net/~wetmore/8061842/webrev.04/ On 8/25/2016 8:05 PM, Weijun Wang wrote: Can you add a new @run line which is the getNameCount()==1 but getParent() != policyPath case? + * @run main/othervm TestUnlimited /unlimited exception I think I finally developed a stable cross-pl

Re: RFR: 8150158: Update bugs.sun.com references to bugs.java.com

Looks ok to me, or bugs.o.j.n which might be more permanent. Brad On 8/25/2016 12:55 PM, Sean Mullan wrote: Real trivial fix, just updating obsolete bug URLs in code comments. bug: https://bugs.openjdk.java.net/browse/JDK-8150158 $ hg diff --nodates -a -U 1 diff -r 9c7eb3e1799f src/java.xml.

RFR 8157404: Unable to read certain PKCS12 keystores from SequenceInputStream

Hello, please review this fix. It's not possible to read PKCS12 keystore with big undefined length DER value in it from SequenceInputStream. Root cause of the problem is that sun.security.util.DerValue relays on InputStream.available() to get a complete 'indefinite.length' section length and

Re: RFR: 8061842: Package jurisdiction policy files as something other than JAR

On 08/24/2016 08:21 PM, Bradford Wetmore wrote: Sean Mullan wrote: > What about setting the default value to "limited"? And then this > would only be changed to "unlimited" if the build --enable-unlimited- > crypto option is specified? I could, but I'm concerned that a build with --enabled-u

Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

Thank you! On 26.08.2016 16:49, Xuelei Fan wrote: Looks fine to me. Thanks, Xuelei On 8/26/2016 6:51 PM, Svetlana Nikandrova wrote: Ok, it's better to be safe than sorry. Added othervm: http://cr.openjdk.java.net/~snikandrova/8164533/webrev.01/

Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

Looks fine to me. Thanks, Xuelei On 8/26/2016 6:51 PM, Svetlana Nikandrova wrote: Ok, it's better to be safe than sorry. Added othervm: http://cr.openjdk.java.net/~snikandrova/8164533/webrev.01/ Thank you, Svetlana On 25.08.2016

Re: RFR: 8024714: In java.security file, ocsp.responderCertSubjectName should not contain quotes

Looks fine to me. > On 26 Aug 2016, at 13:13, Sean Mullan wrote: > > https://bugs.openjdk.java.net/browse/JDK-8024714 > > A trivial fix to remove the quotes from the ocsp property name examples in > the java.security file as they should not be included and will cause a > parsing exception if

RFR: 8024714: In java.security file, ocsp.responderCertSubjectName should not contain quotes

https://bugs.openjdk.java.net/browse/JDK-8024714 A trivial fix to remove the quotes from the ocsp property name examples in the java.security file as they should not be included and will cause a parsing exception if included: $ hg diff -U 1 --nodates diff -r 8c0d4a9bfea1 src/java.base/share/c

Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

Ok, it's better to be safe than sorry. Added othervm: http://cr.openjdk.java.net/~snikandrova/8164533/webrev.01/ Thank you, Svetlana On 25.08.2016 19:02, Xuelei Fan wrote: Just a quick reply. 1. The close is necessary. 2. Run in

RE: [9] RFR: 8015595: Test sun/security/krb5/auto/Unreachable.java fails with Timeout error

Hi, Here is the latest webrev: http://cr.openjdk.java.net/~ssahoo/8015595/webrev.00/ I have updated the test with these additional support, 1) Verifying, if the port is reachable or PortUnreachableException is supported by the platform, otherwise the Test will terminate itself with

Re: RFR 8074838: Resolve disabled warnings for libj2pkcs11

Looks ok to me. /Erik On 2016-08-25 23:20, Anthony Scarpino wrote: Hi, Can I get a review of this change to remove the warning suppression and fix the minor compiler issues that it was hiding in the pkcs11 wrapper library. http://cr.openjdk.java.net/~ascarpino/8074838/webrev/ thanks Tony