Re: [8u-dev] Request for Review & Approval - 8163304: jarsigner -verbose -verify should print the algorithms used to sign the jar

2016-10-20 Thread Seán Coffey
Approved. Regards, Sean. On 21 October 2016 03:38:20 GMT+01:00, Wang Weijun wrote: > > >On Oct 21, 2016, at 10:31 AM, Rob McKenna >wrote: > >Hi folks, > >Looking for a codereview and push approval for the following: > >bug:

RFR[9] JDK-8168064: sun/security/ssl/ServerHandshaker/AnonCipherWithWantClientAuth.java failed with "Received fatal alert: handshake_failure"

2016-10-20 Thread John Jiang
Hi, Please review this patch for fixing an intermittent issue on test sun/security/ssl/ServerHandshaker/AnonCipherWithWantClientAuth.java. The fix applies the pattern from test/javax/net/ssl/templates/SSLSocketSample.java Webrev: http://cr.openjdk.java.net/~jjiang/8168064/webrev.00/ Issue:

Re: [8u-dev] Request for Review & Approval - 8163304: jarsigner -verbose -verify should print the algorithms used to sign the jar

2016-10-20 Thread Wang Weijun
On Oct 21, 2016, at 10:31 AM, Rob McKenna wrote:Hi folks,Looking for a codereview and push approval for the following:bug: https://bugs.openjdk.java.net/browse/JDK-81633049 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7a25dbe45e618 webrev:

[8u-dev] Request for Review & Approval - 8163304: jarsigner -verbose -verify should print the algorithms used to sign the jar

2016-10-20 Thread Rob McKenna
Hi folks, Looking for a codereview and push approval for the following: bug: https://bugs.openjdk.java.net/browse/JDK-8163304 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7a25dbe45e61 8 webrev: http://cr.openjdk.java.net/~robm/8163304/webrev.02/ Thanks, -Rob

Re: RFR: 8168313: Tighten permissions granted to jdk.crypto.pkcs11 module

2016-10-20 Thread Anthony Scarpino
On 10/20/2016 08:22 AM, Sean Mullan wrote: Please review this change to tighten or remove unnecessary permissions granted to the jdk.crypto.pkcs11 module: http://cr.openjdk.java.net/~mullan/webrevs/8168313/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8168313 In doing so, I refactored

Re: [8u-dev] Request for Review and Approval to backport: 8167591: Add MD5 to signed JAR restrictions

2016-10-20 Thread Seán Coffey
Approved. Regards, Sean. On 20/10/2016 22:06, Anthony Scarpino wrote: On 10/20/2016 11:15 AM, Ivan Gerasimov wrote: Hello! Would you please help review and give the approval to backport this fix? The changes in the backport, comparing to the fix in 9, are due to different file structure and

Re: [8u-dev] Request for Review and Approval to backport: 8167591: Add MD5 to signed JAR restrictions

2016-10-20 Thread Anthony Scarpino
On 10/20/2016 11:15 AM, Ivan Gerasimov wrote: Hello! Would you please help review and give the approval to backport this fix? The changes in the backport, comparing to the fix in 9, are due to different file structure and the different previous value of the property. Bug:

[8u-dev] Request for Review and Approval to backport: 8167591: Add MD5 to signed JAR restrictions

2016-10-20 Thread Ivan Gerasimov
Hello! Would you please help review and give the approval to backport this fix? The changes in the backport, comparing to the fix in 9, are due to different file structure and the different previous value of the property. Bug: https://bugs.openjdk.java.net/browse/JDK-8167591 Jdk9 change:

RFR 9044691: Memory leak in JceSecurity

2016-10-20 Thread Bradley Hess
I posted an issue (assigned ID # 90444691) using the public facing bug submission page, as I don't have an OpenJDK account. There's a slow memory leak in JceSecurity. The original source uses an IdentityHashMap, which I believe is done to avoid a case where a trusted Provider has a bad

RFR: 8168313: Tighten permissions granted to jdk.crypto.pkcs11 module

2016-10-20 Thread Sean Mullan
Please review this change to tighten or remove unnecessary permissions granted to the jdk.crypto.pkcs11 module: http://cr.openjdk.java.net/~mullan/webrevs/8168313/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8168313 In doing so, I refactored the code a little to not use

RFR 8167646: Better invalid FilePermission

2016-10-20 Thread Wang Weijun
Please review the code change at http://cr.openjdk.java.net/~weijun/8167646/webrev.00/ A new flag invalid is added so invalid FilePermissions (invalid Path) do not equal or imply or is implied by anything else except for itself. Thanks Max

Re: RFR 8168374: TsacertOptionTest.java fails on all platforms

2016-10-20 Thread Vincent Ryan
Your fix looks fine to me. Thanks. > On 20 Oct 2016, at 05:21, Wang Weijun wrote: > > Please review this test change: > > diff --git a/test/sun/security/tools/jarsigner/TsacertOptionTest.java > b/test/sun/security/tools/jarsigner/TsacertOptionTest.java > ---