Re: Code review request, JDK-8168822, Document that algorithm restrictions do not apply to trusted certs

Hi Sean, Thanks for the review. I will use trust your suggested words. Xuelei On 10/28/2016 4:42 AM, Sean Mullan wrote: I'm not sure I like the word "trusted". That is too general and fairly subjective. I would say the following: "do not apply to trust anchors or self-signed certificates".

Re: Code review request, JDK-8168822, Document that algorithm restrictions do not apply to trusted certs

I'm not sure I like the word "trusted". That is too general and fairly subjective. I would say the following: "do not apply to trust anchors or self-signed certificates". --Sean On 10/26/2016 08:37 PM, Xuelei Fan wrote: New webrev: http://cr.openjdk.java.net/~xuelei/8168822/webrev.01/

Re: RFR: 8168851: Tighten permissions granted to the java.smartcardio module

> On Oct 27, 2016, at 10:00 AM, Sean Mullan wrote: > > I accidentally used the wrong bugid. I have updated the Subject line and > links to reflect that this fix is for the java.smartcardio module, not the > jdk.crypto.ucrypto module: > > https://bugs.openjdk.java.net/browse/JDK-8168851 > http

Re: RFR: 8168851: Tighten permissions granted to the java.smartcardio module

Your fix still looks fine to me. > On 27 Oct 2016, at 18:00, Sean Mullan wrote: > > I accidentally used the wrong bugid. I have updated the Subject line and > links to reflect that this fix is for the java.smartcardio module, not the > jdk.crypto.ucrypto module: > > https://bugs.openjdk.java

Re: RFR: 8168851: Tighten permissions granted to the java.smartcardio module

I accidentally used the wrong bugid. I have updated the Subject line and links to reflect that this fix is for the java.smartcardio module, not the jdk.crypto.ucrypto module: https://bugs.openjdk.java.net/browse/JDK-8168851 http://cr.openjdk.java.net/~mullan/webrevs/8168851/webrev.00/ --Sean

Re: RFR: 8167512: Tighten permissions granted to the jdk.crypto.ucrypto module

Your fix looks fine to me Sean. > On 27 Oct 2016, at 17:09, Sean Mullan wrote: > > Please review this change to tighten or remove unnecessary permissions > granted to the jdk.crypto.ucrypto module: > > https://bugs.openjdk.java.net/browse/JDK-8167512 > http://cr.openjdk.java.net/~mullan/webrev

RFR: 8167512: Tighten permissions granted to the jdk.crypto.ucrypto module

Please review this change to tighten or remove unnecessary permissions granted to the jdk.crypto.ucrypto module: https://bugs.openjdk.java.net/browse/JDK-8167512 http://cr.openjdk.java.net/~mullan/webrevs/8167512/webrev.00/ Thanks, Sean

Re: Code Review Request, JDK-8167680, DTLS implementation bugs

Updated to handle handle optional CertificateVerify message: http://cr.openjdk.java.net/~xuelei/8167680/webrev.02/ Thanks, Xuelei On 10/21/2016 11:31 AM, Xuelei Fan wrote: Updated webrev per Jamil's comments: http://cr.openjdk.java.net/~xuelei/8167680/webrev.01/ Xuelei On 10/13/2016