Re: RFR: 8168911: Increased number of classes initialized during initialization of SignatureFileVerifier

2016-11-07 Thread Anthony Scarpino
On 11/04/2016 08:09 AM, Claes Redestad wrote: Hi, changes to SignatureFileVerifier in 9+142 has some startup implications, and a small cleanup to avoid some trivial regexes etc reduces number of classes initialized in affected startup tests by 61, undoing most of the observed regression. Webrev

Re: [9] RFR: 8168882: keytool doesn't print certificate info if disabled algorithm was used for signing a jar

2016-11-07 Thread Wang Weijun
Everything looks fine now. --Max > On Nov 8, 2016, at 11:09 AM, Artem Smotrakov > wrote: > > Here is final version (I hope) > > http://cr.openjdk.java.net/~asmotrak/8168882/webrev.04/ > > Artem

Re: [9] RFR: 8168882: keytool doesn't print certificate info if disabled algorithm was used for signing a jar

2016-11-07 Thread Artem Smotrakov
Here is final version (I hope) http://cr.openjdk.java.net/~asmotrak/8168882/webrev.04/ Artem On 11/07/2016 06:50 PM, Artem Smotrakov wrote: Hi Max, Sure, I'll add a comment which explains why keytool resets that security property. I didn't notice any strange thing happening if SSL server

Re: [9] RFR: 8168882: keytool doesn't print certificate info if disabled algorithm was used for signing a jar

2016-11-07 Thread Artem Smotrakov
Hi Max, Sure, I'll add a comment which explains why keytool resets that security property. I didn't notice any strange thing happening if SSL server uses weak algorithms. Please see updated PrintSSL.java which now uses MD5withRSA. Artem On 11/07/2016 06:45 PM, Wang Weijun wrote: Hi Artem

Re: [9] RFR: 8168882: keytool doesn't print certificate info if disabled algorithm was used for signing a jar

2016-11-07 Thread Wang Weijun
Hi Artem Change looks fine, but you can add a comment in keytool/Main on why you want to set that security property. BTW, you mentioned keytool -printcert -sslserver the other time. Is there any strange thing happening if the SSL server is using weak cert/cipher? Thanks Max > On Nov 8, 2016,

Re: [9] RFR: 8168882: keytool doesn't print certificate info if disabled algorithm was used for signing a jar

2016-11-07 Thread Artem Smotrakov
Sean, Max, Please take a look at http://cr.openjdk.java.net/~asmotrak/8168882/webrev.03/ It doesn't print a warning anymore, and reset the security property only if -jarfile specified. I also updated a couple of tests to check if "-printcert" works fine. Artem On 11/03/2016 05:47 PM, Art

Re: Updates to documentation for JEP 287

2016-11-07 Thread Sean Mullan
There's a bug open to update the Standard Names doc to include SHA-3: https://bugs.openjdk.java.net/browse/JDK-8004078 The security guides typically get updated a bit later. I don't have an estimate but it will be done before 9 is released. Thanks, Sean On 10/29/16 11:08 AM, Jurrian Fahner

Re: RFR: 8157561 :Ship the unlimited policy files in JDK Updates

2016-11-07 Thread Bradford Wetmore
Great, thanks. Looks good. Brad On 11/7/2016 3:34 AM, Seán Coffey wrote: Thanks for review Brad. I've included an extra check in CryptoLevel to check for "limited/unlimited" input. Addressed the JceSecurity indentation issue also. http://cr.openjdk.java.net/~coffeys/webrev.8157561.8u.jdk.v5

Re: Code Review Request, JDK-8169318, Dump the reproduced packet in DTLSOverDatagram.java

2016-11-07 Thread Sean Mullan
Looks fine to me. --Sean On 11/7/16 7:00 AM, Xuelei Fan wrote: Hi, Please review this test update: http://cr.openjdk.java.net/~xuelei/8169318/webrev.00/ This update is related to JDK-8169086. From the debug log of JDK-8169086, it is hard to tell the failure is cause by anti-free-port iss

Code Review Request, JDK-8169318, Dump the reproduced packet in DTLSOverDatagram.java

2016-11-07 Thread Xuelei Fan
Hi, Please review this test update: http://cr.openjdk.java.net/~xuelei/8169318/webrev.00/ This update is related to JDK-8169086. From the debug log of JDK-8169086, it is hard to tell the failure is cause by anti-free-port issue or not. So I filed a new bug JDK-8169318, and want to expose

Re: RFR: 8157561 :Ship the unlimited policy files in JDK Updates

2016-11-07 Thread Seán Coffey
Thanks for review Brad. I've included an extra check in CryptoLevel to check for "limited/unlimited" input. Addressed the JceSecurity indentation issue also. http://cr.openjdk.java.net/~coffeys/webrev.8157561.8u.jdk.v5/webrev/ Regards, Sean. On 04/11/16 22:56, Bradford Wetmore wrote: I didn't

Re: RFR 7004967: SecureRandom should be more explicit about threading

2016-11-07 Thread Wang Weijun
Accepted. Please review http://ccc.us.oracle.com/8169312. In fact, can we deprecate the getSeed() method? It's not unsafe so we don't need to give it a forRemoval value. Thanks Max On 11/4/2016 10:54 PM, Sean Mullan wrote: * SecureRandom 131 * If this attribute is not set or is "false",