Re: RFR: 8169335: Add a crypto.policy fallback in case Security Property 'crypto.policy' does not exist

2016-11-17 Thread Seán Coffey
On 17/11/2016 17:46, Bradford Wetmore wrote: On 11/17/2016 7:19 AM, Seán Coffey wrote: The /policy= jtreg tag was also another possible solution. That's a policy file, not a java.security file. Ah, of course. Wasn't thinking right. regards, Sean. SeanM pointed out that we could do a:

Re: RFR: 8169335: Add a crypto.policy fallback in case Security Property 'crypto.policy' does not exist

2016-11-17 Thread Bradford Wetmore
On 11/17/2016 7:19 AM, Seán Coffey wrote: The /policy= jtreg tag was also another possible solution. That's a policy file, not a java.security file. SeanM pointed out that we could do a: @main -Djava.security.properties=xxx but that would require storing a snapshot of java.security.

Re: RFR: 8169335: Add a crypto.policy fallback in case Security Property 'crypto.policy' does not exist

2016-11-17 Thread Seán Coffey
Looks good to me. I didn't know you could pass a plain file 'name' to java.security.properties. The docs indicate that a URL is required but the jdk code suggests your approach will work. The /policy= jtreg tag was also another possible solution. regards, Sean. On 17/11/2016 01:33, Bradford

RFR(s): JDK-8169866: [TESTBUG] com/sun/security/ tests have undeclared modules dependencies

2016-11-17 Thread Sergei Kovalev
Hello team, Please review a small fix for security tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8169866 Web review: http://cr.openjdk.java.net/~skovalev/8169866/webrev.00/ Issue: Tests from package com/sun/security failing in case of usage "--limit-modules java.base" command line

Re: RFR 7004967: SecureRandom should be more explicit about threading

2016-11-17 Thread Sean Mullan
Looks good. --Sean On 11/15/16 9:55 PM, Wang Weijun wrote: Please review the updated webrev at http://cr.openjdk.java.net/~weijun/7004967/webrev.02/ Only spec change [1]. This change also covers 8169312. Thanks Max [1]