Looks good to me.
/Magnus
> 8 dec. 2016 kl. 00:21 skrev Valerie Peng :
>
> Anyone can help reviewing this?
>
> The fix is straight forward, just renamed the DEBUG to J2UC_DEBUG to address
> the E_MACRO_REDEFINED warning.
> In addition, I also updated the nativeCrypto.h to remove the workarou
On 12/07/2016 03:21 PM, Valerie Peng wrote:
Anyone can help reviewing this?
The fix is straight forward, just renamed the DEBUG to J2UC_DEBUG to
address the E_MACRO_REDEFINED warning.
In addition, I also updated the nativeCrypto.h to remove the workaround
for a Solaris12-specific issue which has
Anyone can help reviewing this?
The fix is straight forward, just renamed the DEBUG to J2UC_DEBUG to
address the E_MACRO_REDEFINED warning.
In addition, I also updated the nativeCrypto.h to remove the workaround
for a Solaris12-specific issue which has now been fixed.
Bug: https://bugs.openj
Thanks for committing, looks fine with me as well.
Gruss
Bernd
On Wed, Dec 7, 2016 at 5:25 PM +0100, "Sean Mullan"
wrote:
Looks good. Minor comment - update the copyright to include 2016 as the
last year it was updated, ex:
* Copyright (c) 2003, 2016, Oracle and/or its affilia
Looks good. Minor comment - update the copyright to include 2016 as the
last year it was updated, ex:
* Copyright (c) 2003, 2016, Oracle and/or its affiliates. All rights
reserved.
Send me the updated diffs and I will push it for you.
--Sean
On 12/7/16 9:14 AM, Adam Petcher wrote:
Minor
Minor improvement/optimization to ISO10126Padding. Simplifies the code a
bit and requests one fewer random byte. No regression test is provided
because this is a code cleanup, and the functionality is covered by
existing tests.
Bug: https://bugs.openjdk.java.net/browse/JDK-8158517
Diff:
di
On 12/6/16 8:00 PM, Xuelei Fan wrote:
new webrev:
http://cr.openjdk.java.net/~xuelei/8170329/webrev.02/
Looks good.
--Sean
