API looks good.
SSLEngineImpl/SSLSocketImpl.java
212/229: I might suggest a more descriptive variable name, like
applicationSelector. "selector" is a bit ambiguous.
450/1379:
getHandshakeApplicationProtocolSelector());
->
selector);
Xuelei wrote:
> This met
On 12/8/2016 6:09 PM, David M. Lloyd wrote:
> How could it turn out to be incorrect, ...
Here is some potentials regarding the cipher suite and application protocol:
C1. select cipher suite at first, and then select the application protocol.
There is an issue if there is no application protocol su
Looks good.
Tony
On 12/09/2016 12:54 PM, Xuelei Fan wrote:
Hi,
Please review this typo issue introduced in JDK-8170329.
$ hg diff test/sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java
@Override
-protected boolean isCustomizeClientConnection() {
+protected boolean isCust
Looks fine to me.
--Sean
On 12/9/16 3:54 PM, Xuelei Fan wrote:
Hi,
Please review this typo issue introduced in JDK-8170329.
$ hg diff test/sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java
@Override
-protected boolean isCustomizeClientConnection() {
+protected boolean isC
Thanks for your detailed review Brad. I’ve generated a new webrev:
http://cr.openjdk.java.net/~vinnie/8170282/webrev.01/
> On 9 Dec 2016, at 01:34, Bradford Wetmore wrote:
>
>
> Hi Vinnie,
>
> On 12/8/2016 2:18 PM, Vincent Ryan wrote:
>> The Java Servlet Expect Group reported that they h
Hi,
Please review this typo issue introduced in JDK-8170329.
$ hg diff test/sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java
@Override
-protected boolean isCustomizeClientConnection() {
+protected boolean isCustomizedClientConnection() {
return true;
}
$ hg d
Looks good to me. Please add a noreg label (noreg-cleanup or
noreg-trivial probably) to the bug.
--Sean
On 12/9/16 10:53 AM, Adam Petcher wrote:
KeychainStore has a couple of @SuppressWarnings("deprecation")
annotations that were required due to references to an overloaded equals
method in Ob
Hi,
On Fri, Dec 9, 2016 at 3:09 AM, David M. Lloyd wrote:
> On 12/08/2016 07:34 PM, Bradford Wetmore wrote:
>>
>> Hi,
>>
>> Vinnie wrote:
>>>
>>> We understood when we examined these issues last year that the
>>> existing ALPN API would be sufficient. However it transpired,
>>> following HTTP2 se
KeychainStore has a couple of @SuppressWarnings("deprecation")
annotations that were required due to references to an overloaded equals
method in ObjectIdentifier that was marked as deprecated. This method
has since been removed, so these calls now resolve to a non-deprecated
method.
Bug: h
