RFR 8171340: HttpNegotiateServer/java test should not use system proxy on Mac

2016-12-15 Thread Wang Weijun
Please take a review at http://cr.openjdk.java.net/~weijun/8171340/webrev.00/ All "openConnection()" modified to "openConnection(Proxy.NO_PROXY)". Everything else is whitespace change. Thanks Max

Re: [9] RFR 8170282: Enable ALPN parameters to be supplied during the TLS handshake

2016-12-15 Thread Xuelei Fan
On 12/15/2016 5:15 PM, Bradford Wetmore wrote: (Xuelei, question for you below) Hi Vinnie, There is no test yet for SSLEngine/SSLSocket: public BiFunction, String> getHandshakeApplicationProtocolSelector() { Tests are passing at 100% with latest jdk.patch. SSLSocketImpl.ja

Re: [9] RFR 8170282: Enable ALPN parameters to be supplied during the TLS handshake

2016-12-15 Thread Bradford Wetmore
(Xuelei, question for you below) Hi Vinnie, There is no test yet for SSLEngine/SSLSocket: public BiFunction, String> getHandshakeApplicationProtocolSelector() { Tests are passing at 100% with latest jdk.patch. SSLSocketImpl.java == 2672: Sorry, but I think wh

Re: [9] RFR 8170282: Enable ALPN parameters to be supplied during the TLS handshake

2016-12-15 Thread Vincent Ryan
Thanks Brad for those review comments. I’ve make some implementation changes and updated the existing ALPN tests. No public API changes. A new webrev is available at: http://cr.openjdk.java.net/~vinnie/8170282/webrev.02/ > On 9 Dec 2016,

Re: [9] RFR: 8166531: sun/security/ssl/SocketCreation/SocketCreation.java fails intermittently

2016-12-15 Thread Artem Smotrakov
Hi Xuelei, I am not sure either, but I would like to try. If it doesn't work, we can go and re-write the test to follow SSLSocketTemplate. Actually, I don't think it is really possible because SSLSocketTemplate uses connect() method which is not used by the test. Artem On 12/15/2016 02:04

Re: [9] RFR: 8166531: sun/security/ssl/SocketCreation/SocketCreation.java fails intermittently

2016-12-15 Thread Xuelei Fan
I'm not sure this update would work. As this is a special test, it might be possible to copy/past and update the template code (or old sample code) here as we did to use the old template. Xuelei On 12/15/2016 11:23 AM, Artem Smotrakov wrote: Hello, Please review the patch below for sun/sec

[PATCH] 8170876: NPE in Cipher with java.security.debug=provider

2016-12-15 Thread Adam Petcher
I'm continuing my quest to rid engine classes of NullPointerException due to calling getName() on a null provider. This patch fixes Cipher (which fails in a test using NullCipher) and all other engine classes that have this pattern. I found them by searching the codebase for references to Provi

[9] RFR: 8166531: sun/security/ssl/SocketCreation/SocketCreation.java fails intermittently

2016-12-15 Thread Artem Smotrakov
Hello, Please review the patch below for sun/security/ssl/SocketCreation/SocketCreation.java test. The test has been observed to fail intermittently, but I couldn't reproduce it by running the test in a loop. The test creates sockets for TLS connection in different ways. Even if the test is