Hi,
Please review the following patch,
JBS: https://bugs.openjdk.java.net/browse/JDK-8161232
Webrev: http://cr.openjdk.java.net/~ssahoo/8161232/webrev.00/
Description:
It was reported the Test was failing with timeout consistently on macOS. There
is no log available anymore and the i
On 12/20/2016 10:12 PM, John Jiang wrote:
Hi Xuelei,
Thanks for you comments.
Please review the updated webrev:
http://cr.openjdk.java.net/~jjiang/8168935/webrev.01/
Looks fine to me.
The updated version adds method configureServerSocket(SSLServerSocket
socket) only, because the other two m
Hi Xuelei,
Thanks for you comments.
Please review the updated webrev:
http://cr.openjdk.java.net/~jjiang/8168935/webrev.01/
The updated version adds method configureServerSocket(SSLServerSocket
socket) only, because the other two methods has no association to this fix.
And it looks the existin
On 12/20/16 4:31 PM, Adam Petcher wrote:
KeyPairGenerator didn't require any changes because that class does not
reference its provider member. KeyPairGenerator.Delegate has similar
code that prints the name of its provider, but this is not an instance
of the pattern that I was addressing, and I
KeyPairGenerator didn't require any changes because that class does not
reference its provider member. KeyPairGenerator.Delegate has similar
code that prints the name of its provider, but this is not an instance
of the pattern that I was addressing, and I don't have any reason to
believe there
I think you missed java.security.KeyPairGenerator which has the same
issue. Otherwise looks good.
--Sean
On 12/15/16 3:08 PM, Adam Petcher wrote:
I'm continuing my quest to rid engine classes of NullPointerException
due to calling getName() on a null provider. This patch fixes Cipher
(which fa
New: http://cr.openjdk.java.net/~xuelei/8129988/webrev.01/
On 12/19/2016 12:35 PM, Sean Mullan wrote:
Here are more comments on TrustStoreManager:
87-93: these variables can be declared private
120 new PrivilegedAction() {
use <> operator
Updated.
152
Hi John,
I was wondering to add three methods in the template:
. configureClientSocket(SSLSocket socket)
. configureServerSocket(SSLSocket socket)
. configureServerSocket(SSLServerSocket socket)
However, there was no use of any of them of my previous update, so we
did not add them. Your adding
Hi,
In test sun/security/ssl/SSLContextImpl/TrustTrustedCert.java, the
server may wait for the client for a long time, then the test execution
goes to timeout.
This patch takes advantage of
javax/net/ssl/templates/SSLSocketTemplate.java to fix this issue.
Please note that:
1. SSLSocketTemplat
