RFR 8170732: GssKrb5Client sends non-zero buffer size when qop is "auth"

2016-12-21 Thread Wang Weijun
Please take a review at http://cr.openjdk.java.net/~weijun/8170732/webrev.00/ According to https://tools.ietf.org/html/rfc4752#section-3.1: The client then constructs data, with the first octet containing the bit-mask specifying the selected security layer, the second through fourth o

Re: Code Review Request, 6972386 issues with String.toLowerCase/toUpperCase

2016-12-21 Thread Wang Weijun
Change looks fine. Thanks for taking care of CtrDrbg.java. I've make quite some changes like this and it's a shame I missed it in my own code. --Max > On Dec 22, 2016, at 4:05 AM, Xuelei Fan wrote: > > Hi, > > Please review the fix: > > http://cr.openjdk.java.net/~xuelei/6972386/webrev.00

Re: RFR 8170900: Issue with FilePermission::implies for wildcard flag(-)

2016-12-21 Thread Wang Weijun
> On Dec 22, 2016, at 8:12 AM, Xuelei Fan wrote: > > I think the note is an example, may not need an additional CCC. That's always my understanding. > > For easier reading, I may use a contrast example. For example, "Note that > this means "/-" implies "/foo" but not "foo".". Good advice.

Re: RFR 8170900: Issue with FilePermission::implies for wildcard flag(-)

2016-12-21 Thread Xuelei Fan
I think the note is an example, may not need an additional CCC. For easier reading, I may use a contrast example. For example, "Note that this means "/-" implies "/foo" but not "foo".". Use the one you like, I'm OK with the either. Xuelei On 12/21/2016 3:58 PM, Wang Weijun wrote: On Dec

An Unexpected I/O exception with AsyncHttpClient while performing SSL requests

2016-12-21 Thread Shlomi Abramoviz
Hi everyone, I was referred to this group and I hope this is the right place and would really appreciate if you could share your opinion with me. My company works with Play framework and Scala as our backend server. Lately we've been having problems with the server. While making a secured (SSL) re

Re: RFR 8170900: Issue with FilePermission::implies for wildcard flag(-)

2016-12-21 Thread Wang Weijun
> On Dec 22, 2016, at 4:39 AM, Xuelei Fan wrote: > > I'm trying to understand this update. Does "/-" imply "/foo"? Yes. > > Does the following spec can be used to explain the new added note? > > * if the wildcard flag is "-", the simple pathname's path > * must be recursivel

Re: RFR 8170900: Issue with FilePermission::implies for wildcard flag(-)

2016-12-21 Thread Xuelei Fan
I'm trying to understand this update. Does "/-" imply "/foo"? Does the following spec can be used to explain the new added note? * if the wildcard flag is "-", the simple pathname's path * must be recursively inside the wildcard pathname's path. Xuelei On 12/19/2016 11:25 PM

Code Review Request, 6972386 issues with String.toLowerCase/toUpperCase

2016-12-21 Thread Xuelei Fan
Hi, Please review the fix: http://cr.openjdk.java.net/~xuelei/6972386/webrev.00/ Change to use the language/country neutral locale for the locale sensitive operations. Thanks, Xuelei

Re: [9] RFR 8161232: AsyncSSLSocketClose.java test fails timeout.

2016-12-21 Thread Xuelei Fan
Looks good to me. Thanks, Xuelei On 12/20/2016 11:34 PM, Sibabrata Sahoo wrote: Hi, Please review the following patch, JBS: https://bugs.openjdk.java.net/browse/JDK-8161232 Webrev: http://cr.openjdk.java.net/~ssahoo/8161232/webrev.00/ Description: It was reported the Test was failing