+1.
Brad
On 12/22/2016 8:58 AM, Xuelei Fan wrote:
Looks fine to me.
Thanks,
Xuelei
On 12/22/2016 2:38 AM, Vincent Ryan wrote:
Please review this spec change to allow an ALPN callback function to
also disable ALPN usage
and return no ALPN extension value during a TLS handshake.
Thanks.
Bu
updated: http://cr.openjdk.java.net/~xuelei/8129988/webrev.02/
On 12/22/2016 9:32 AM, Sean Mullan wrote:
On 12/20/16 3:21 PM, Xuelei Fan wrote:
213 if (storePassword != null &&
!storePassword.isEmpty()) {
214 MessageDigest md =
JsseJce.getMessageDigest("SHA-256");
On 12/20/16 3:21 PM, Xuelei Fan wrote:
213 if (storePassword != null && !storePassword.isEmpty()) {
214 MessageDigest md =
JsseJce.getMessageDigest("SHA-256");
215 result = 31 * result +
216 Arrays.hashCode(md.digest(storePassword.getBytes()));
21
Looks fine to me.
Thanks,
Xuelei
On 12/22/2016 2:38 AM, Vincent Ryan wrote:
Please review this spec change to allow an ALPN callback function to also
disable ALPN usage
and return no ALPN extension value during a TLS handshake.
Thanks.
Bug: https://bugs.openjdk.java.net/browse/JDK-8171443
W
144InputStream sslIS = socket.getInputStream();
This variable is not used and can be removed. Otherwise, looks fine to me.
Xuelei
On 12/22/2016 1:20 AM, Tim Du wrote:
Hi All:
Would like help to review the code change for
javax/net/ssl/TLSv12/DisabledShortRSAKeys.java? The test case faile
Hello Simone,
Throwing an exception is certainly another option but we chose these 3 specific
return values for the callback
so that they match the existing behaviour of SSLEngine.getApplicationProtocol /
SSLEngine.getHandshakeApplicationProtocol
and the SSLSocket equivalents.
http://download.j
Looks good.
regards,
Sean.
On 22/12/2016 09:20, Tim Du wrote:
Hi All:
Would like help to review the code change for
javax/net/ssl/TLSv12/DisabledShortRSAKeys.java? The test case failed
with synchronization test issue between client and server
intermittently, use advantage of SSLSocketSample
Your JDK version is quite old. Try updating to the latest JDK 8u release.
this might be a factor and was fixed in 8u51.
http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/445debb5c61d
Sean.
On 21/12/2016 19:43, Shlomi Abramoviz wrote:
Hi everyone,
I was referred to this group and I hope this is th
Vincent,
On Thu, Dec 22, 2016 at 11:38 AM, Vincent Ryan
wrote:
> Please review this spec change to allow an ALPN callback function to also
> disable ALPN usage
> and return no ALPN extension value during a TLS handshake.
As I understand it, the callback needs to convey 3 results:
1. a success -
Please review this spec change to allow an ALPN callback function to also
disable ALPN usage
and return no ALPN extension value during a TLS handshake.
Thanks.
Bug: https://bugs.openjdk.java.net/browse/JDK-8171443
Webrev: http://cr.openjdk.java.net/~vinnie/8171443/webrev.01/
Hi All:
Would like help to review the code change for
javax/net/ssl/TLSv12/DisabledShortRSAKeys.java? The test case failed
with synchronization test issue between client and server
intermittently, use advantage of SSLSocketSample.java to make stable and
get rid of duplicate codes.Thanks.
JB
11 matches
Mail list logo
