Re: Code Review Request JDK-8129988 JSSE should create a single instance of the cacerts KeyStore

2017-01-04 Thread Xuelei Fan
New webrev: http://cr.openjdk.java.net/~xuelei/8129988/webrev.04/ On 1/4/2017 1:27 PM, Sean Mullan wrote: It's unfortunate that the previous code read the system properties each time a TrustManagerFactory was initialized. I think in practice, if applications are changing these system properties

Re: Code Review Request JDK-8129988 JSSE should create a single instance of the cacerts KeyStore

2017-01-04 Thread Sean Mullan
It's unfortunate that the previous code read the system properties each time a TrustManagerFactory was initialized. I think in practice, if applications are changing these system properties on the fly it isn't going to work predictably. This implementation would have been much simpler if the pr

Re: Code Review Request JDK-8129988 JSSE should create a single instance of the cacerts KeyStore

2017-01-04 Thread Xuelei Fan
Updated to use synchronized method. Most of the time, the synchronized only perform the read access to the variables. The impact on performance should be acceptable. http://cr.openjdk.java.net/~xuelei/8129988/webrev.03/ Only the TrustStoreManager.java implementation get updated in this web

Re: [8u] RFA for backport of JDK-8157665: ProblemList.txt needs to be updated as 7041639 closed

2017-01-04 Thread Seán Coffey
The changes look fine. Please ensure that the tests pass on JPRT solaris platforms before pushing. Approved. Regards, Sean. On 04/01/17 07:02, Nikita Jain wrote: Sorry, I made a mistake. The trivial backport requires a code review. JDK8 webrev link is mentioned in previous mail. The ch