Re: 8172529: Use PKIXValidator in jarsigner

2017-01-16 Thread Xuelei Fan
Ok. Looks good. Xuelei > On Jan 16, 2017, at 6:09 PM, Weijun Wang wrote: > > > >> On 01/17/2017 01:26 AM, Xuelei Fan wrote: >>> On 1/15/2017 5:42 PM, Weijun Wang wrote: >>> Sorry, wrong subject, resending. >>> On 01/16/2017 09:41 AM, Weijun Wang wrote: Please review the code chang

Re: 8172529: Use PKIXValidator in jarsigner

2017-01-16 Thread Weijun Wang
On 01/17/2017 01:26 AM, Xuelei Fan wrote: On 1/15/2017 5:42 PM, Weijun Wang wrote: Sorry, wrong subject, resending. On 01/16/2017 09:41 AM, Weijun Wang wrote: Please review the code change at http://cr.openjdk.java.net/~weijun/8172529/webrev.02 The validator is updated to be a PKIXValidato

Re: RFR: 8037325: Class.getConstructor() performance regression

2017-01-16 Thread Mandy Chung
> On Jan 16, 2017, at 1:59 PM, Claes Redestad wrote: > > http://cr.openjdk.java.net/~redestad/8037325/webrev.02/ +1 Mandy

Re: RFR: 8037325: Class.getConstructor() performance regression

2017-01-16 Thread Claes Redestad
On 2017-01-16 22:39, Mandy Chung wrote: On Jan 12, 2017, at 6:48 AM, Claes Redestad wrote: Hi, please review this fix to various performance regressions observed as the security model has evolved over the years. Bug: https://bugs.openjdk.java.net/browse/JDK-8037325 Webrev: http://cr.openj

Re: RFR: 8037325: Class.getConstructor() performance regression

2017-01-16 Thread Mandy Chung
> On Jan 12, 2017, at 6:48 AM, Claes Redestad wrote: > > Hi, > > please review this fix to various performance regressions observed > as the security model has evolved over the years. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8037325 > Webrev: http://cr.openjdk.java.net/~redestad/80373

Re: 8172529: Use PKIXValidator in jarsigner

2017-01-16 Thread Xuelei Fan
On 1/15/2017 5:42 PM, Weijun Wang wrote: Sorry, wrong subject, resending. On 01/16/2017 09:41 AM, Weijun Wang wrote: Please review the code change at http://cr.openjdk.java.net/~weijun/8172529/webrev.02 The validator is updated to be a PKIXValidator of the Validator.VAR_CODE_SIGNING varian

Re: Feedback on SSLEngine.setHandshakeApplicationProtocolSelector()

2017-01-16 Thread Vincent Ryan
That’s good news. Thanks for validating the new mechanism in Jetty. > On 12 Jan 2017, at 19:04, Simone Bordet wrote: > > Hi, > > On Wed, Jan 11, 2017 at 5:57 PM, Simone Bordet > wrote: >> Hi, >> >> I just wanted to report that I have implemented the new mechanism >> provided by SSLEngine.se

Re: RFR 8172422: jarsigner needs to understand -?

2017-01-16 Thread Alan Bateman
On 16/01/2017 01:41, Weijun Wang wrote: Please review the code change at http://cr.openjdk.java.net/~weijun/8172529/webrev.02 The validator is updated to be a PKIXValidator of the Validator.VAR_CODE_SIGNING variant. In order to have the same output message and exit code as before, the Va