Re: RFR 8172527: Rename jdk.crypto.token to jdk.crypto.cryptoki

2017-01-20 Thread Mandy Chung
> On Jan 20, 2017, at 10:22 AM, Anthony Scarpino > wrote: > > Good catch.. that'll teach me for trusting the graphical tool to rename a > directory when I used 'Rename'. > > Also I found Brad's issue as it was a new changeset that just showed up in > that file.

Re: RFR 8172527: Rename jdk.crypto.token to jdk.crypto.cryptoki

2017-01-20 Thread Anthony Scarpino
On 01/19/2017 11:50 AM, Mandy Chung wrote: On Jan 19, 2017, at 11:39 AM, Anthony Scarpino wrote: Hi, I need a review to rename the jdk.crypto.token to jdk.crypto.cryptoki. This is to change what 8171202 had done to the original jdk.crypto.pkcs11 module. For

Re: RFR 8172975: SecurityTools.keytool() needs to accept user input

2017-01-20 Thread Weijun Wang
Thanks. All suggestions accepted. Will push after updated. --Max On 01/20/2017 08:01 PM, Artem Smotrakov wrote: It might be better to remove the response file in a finally block. Main.java needs new copyright year. Otherwise, looks fine. I see you removed public sign() and verify() methods

Re: RFR 8172975: SecurityTools.keytool() needs to accept user input

2017-01-20 Thread Artem Smotrakov
It might be better to remove the response file in a finally block. Main.java needs new copyright year. Otherwise, looks fine. I see you removed public sign() and verify() methods in SecurityTools, please make sure that they are not used by other tests. Artem On 01/20/2017 02:44 PM, Weijun

Re: RFR 8172975: SecurityTools.keytool() needs to accept user input

2017-01-20 Thread Weijun Wang
Updated http://cr.openjdk.java.net/~weijun/8172975/root/webrev.01/ http://cr.openjdk.java.net/~weijun/8172975/webrev.01/ I'll need this in my other work. Thanks Max On 01/20/2017 07:23 PM, Artem Smotrakov wrote: It's up to you. You can change it now if you have time, or we can do it once we

Re: RFR 8172975: SecurityTools.keytool() needs to accept user input

2017-01-20 Thread Artem Smotrakov
It's up to you. You can change it now if you have time, or we can do it once we need to update jarsigner tests. Artem On 01/20/2017 12:23 PM, Weijun Wang wrote: Also, I am feeling that the jarsigner-related calls are quite complicated. I suggest we use the same method for signing and

Re: RFR 8172975: SecurityTools.keytool() needs to accept user input

2017-01-20 Thread Weijun Wang
On 01/20/2017 05:01 PM, Artem Smotrakov wrote: Hi Max, Please see inline. On 01/19/2017 05:15 PM, Weijun Wang wrote: On 01/19/2017 09:40 PM, Artem Smotrakov wrote: Hi Max, In general, looks okay. Would it be better if it called redirectInput() only if the response file exists?

Re: RFR 8172975: SecurityTools.keytool() needs to accept user input

2017-01-20 Thread Artem Smotrakov
Hi Max, Please see inline. On 01/19/2017 05:15 PM, Weijun Wang wrote: On 01/19/2017 09:40 PM, Artem Smotrakov wrote: Hi Max, In general, looks okay. Would it be better if it called redirectInput() only if the response file exists? keytool() method might also delete the response file