Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-24 Thread Weijun Wang
The copyright header for src is different from that for test. You need to mention the "Classpath" exception. --Max On 01/25/2017 03:48 AM, Adam Petcher wrote: On 1/24/2017 2:17 PM, Sean Mullan wrote: It looks like there is a leftover import for PolicyUtil in PolicyParser.java. Otherwise loo

Review Request JDK-8172808: Handle sun.security.util.Resources bundle in ResourcesMgr in the same way as AuthResources

2017-01-24 Thread Mandy Chung
Adam, Sean, Can you review this simple fix: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8172808/webrev.00/ This change updates ResourcesMgr to handle both Resources and AuthResources consistently. This removes doPrivileged block because it is not really needed. This is covered by an exis

Re: Code Review Request, JDK-8172869 4096 is not supported yet for the DH Parameter Generator

2017-01-24 Thread Sean Mullan
Looks good. --Sean On 1/24/17 2:24 PM, Xuelei Fan wrote: Hi, Please review this spec documentation update: http://cr.openjdk.java.net/~xuelei/8172869/webrev.00/ In the java.security.AlgorithmParameterGenerator specification, 4096 bits DH parameter generator is specified as a required feat

Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-24 Thread Mandy Chung
> On Jan 24, 2017, at 11:48 AM, Adam Petcher wrote: > > > On 1/24/2017 2:17 PM, Sean Mullan wrote: >> >> It looks like there is a leftover import for PolicyUtil in >> PolicyParser.java. Otherwise looks good and I can push this fix for you >> after you send me an updated patch/webrev. >> >>

Re: Code Review Request, JDK-8172869 4096 is not supported yet for the DH Parameter Generator

2017-01-24 Thread Xuelei Fan
On 1/24/2017 11:46 AM, Anthony Scarpino wrote: On 01/24/2017 11:24 AM, Xuelei Fan wrote: Hi, Please review this spec documentation update: http://cr.openjdk.java.net/~xuelei/8172869/webrev.00/ In the java.security.AlgorithmParameterGenerator specification, 4096 bits DH parameter generator

Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-24 Thread Adam Petcher
On 1/24/2017 2:17 PM, Sean Mullan wrote: It looks like there is a leftover import for PolicyUtil in PolicyParser.java. Otherwise looks good and I can push this fix for you after you send me an updated patch/webrev. --Sean Fixed in the latest webrev: http://cr.openjdk.java.net/~apetcher/8

Re: Code Review Request, JDK-8172869 4096 is not supported yet for the DH Parameter Generator

2017-01-24 Thread Anthony Scarpino
On 01/24/2017 11:24 AM, Xuelei Fan wrote: Hi, Please review this spec documentation update: http://cr.openjdk.java.net/~xuelei/8172869/webrev.00/ In the java.security.AlgorithmParameterGenerator specification, 4096 bits DH parameter generator is specified as a required feature. However, th

Code Review Request, JDK-8172869 4096 is not supported yet for the DH Parameter Generator

2017-01-24 Thread Xuelei Fan
Hi, Please review this spec documentation update: http://cr.openjdk.java.net/~xuelei/8172869/webrev.00/ In the java.security.AlgorithmParameterGenerator specification, 4096 bits DH parameter generator is specified as a required feature. However, the 4096 bits DH parameter generator is not

Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-24 Thread Sean Mullan
On 1/24/17 12:38 PM, Adam Petcher wrote: Thanks Sean and Mandy for the feedback. I believe I incorporated all feedback into the latest patch, with one exception (Sean see below). http://cr.openjdk.java.net/~apetcher/8168075/webrev.02/ In PolicyParser.ParsingException, there is a comment stat

Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-24 Thread Adam Petcher
Thanks Sean and Mandy for the feedback. I believe I incorporated all feedback into the latest patch, with one exception (Sean see below). http://cr.openjdk.java.net/~apetcher/8168075/webrev.02/ On 1/23/2017 12:15 PM, Sean Mullan wrote: On 1/19/17 10:28 AM, Adam Petcher wrote: My last attempt

Re: RFR[9] JDK-8171900: javax/net/ssl/SSLSession/SessionTimeOutTests.java failed with "SSLHandshakeException: Remote host terminated the handshake"

2017-01-24 Thread Xuelei Fan
Hi John, Looks fine to me. Thanks for the update. Xuelei On 1/23/2017 5:17 AM, John Jiang wrote: Hi, The patch takes some code patterns from SSLSocketTemplate.java to try to resolve the following issues: JDK-8171900: javax/net/ssl/SSLSession/SessionTimeOutTests.java failed with "SSLHandshakeE