Re: RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

I looked at the new test: BasicLimited.java This test will fail if "jdk.security.jgss" is specified from jtreg javaoptions: jtreg ... -javaoptions:"--limit-modules java.security.jgss,jdk.security.auth,jdk.security.jgss" jdk9/test/sun/security/krb5/auto/BasicLimited.java Thanks, Amy On 3/14/

Re: RFR 8176715: sun/security/krb5/auto/HttpNegotiateServer.java does not compile

Looks good. (I'm not a reviewer) Thanks, Amy On 3/14/17 11:38 AM, Weijun Wang wrote: Please review the patch below: diff --git a/test/sun/security/krb5/auto/HttpNegotiateServer.java b/test/sun/security/krb5/auto/HttpNegotiateServer.java --- a/test/sun/security/krb5/auto/HttpNegotiateServer.

RFR 8176715: sun/security/krb5/auto/HttpNegotiateServer.java does not compile

Please review the patch below: diff --git a/test/sun/security/krb5/auto/HttpNegotiateServer.java b/test/sun/security/krb5/auto/HttpNegotiateServer.java --- a/test/sun/security/krb5/auto/HttpNegotiateServer.java +++ b/test/sun/security/krb5/auto/HttpNegotiateServer.java @@ -28,6 +28,7 @@ *

Re: RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

Ping again. On 03/07/2017 10:10 PM, Weijun Wang wrote: Please review this changeset at http://cr.openjdk.java.net/~weijun/8176296/webrev.00/ It looks with jdk.security.jgss added into @modules in TEST.properties (JDK-8176213), it cannot be excluded using --limit-modules. Therefore I split

[10] RFR 8175251: Failed to load RSA private key from pkcs12

Hi Sean, Can you please help reviewing the fix for JDK-8175251 "Failed to load RSA private key from pkcs12" Bug: https://bugs.openjdk.java.net/browse/JDK-8175251 Webrev: http://cr.openjdk.java.net/~valeriep/8175251/webrev.00/ Thanks, Valerie

[9] RFR 8175251: Failed to load RSA private key from pkcs12

Re-send with the correct release version. This fix is intended for JDK-9. Thanks, Valerie On 3/13/2017 6:24 PM, Valerie Peng wrote: Hi Sean, Can you please help reviewing the fix for JDK-8175251 "Failed to load RSA private key from pkcs12" Bug: https://bugs.openjdk.java.net/browse/JDK-81752

Re: RFR: JDK-8176503: Disable SHA-1 TLS Server Certificates

That change looks fine to me. Thanks. > On 13 Mar 2017, at 14:57, Sean Mullan wrote: > > Please review this configuration change to disable SHA-1 TLS server > certificates by default in JDK 9. In order to be disabled, the certificates > must chain back to trusted root certificate in the cacer

RFR: JDK-8176503: Disable SHA-1 TLS Server Certificates

Please review this configuration change to disable SHA-1 TLS server certificates by default in JDK 9. In order to be disabled, the certificates must chain back to trusted root certificate in the cacerts keystore that has a " [jdk]" attribute appended to their alias name. --Sean diff --git a/s

Re: RFR 8176542: Missing @Deprecated arguments for jdk.policytool

Looks fine. --Sean On 3/11/17 5:28 AM, Weijun Wang wrote: Please take a review on the patch below. Notes: 1. The current javadoc output expands the arguments into sentences like "Deprecated, for removal: This API element is subject to removal in a future version." which means there is no need