Re: [10] RFR: 8175029: StackOverflowError in X509CRL and X509Certificate.verify(PublicKey, Provider)

2017-03-31 Thread Vincent Ryan
This fix looks fine to me. Thanks. > On 31 Mar 2017, at 16:34, Sean Mullan wrote: > > New webrev uploaded to address your comments: > http://cr.openjdk.java.net/~mullan/webrevs/8175029/webrev.01/ > > --Sean > > On 3/31/17 9:11 AM, Sean Mullan wrote: >> On 3/31/17 9:08 AM, Weijun Wang wrote:

Re: [10] RFR: 8175029: StackOverflowError in X509CRL and X509Certificate.verify(PublicKey, Provider)

2017-03-31 Thread Sean Mullan
New webrev uploaded to address your comments: http://cr.openjdk.java.net/~mullan/webrevs/8175029/webrev.01/ --Sean On 3/31/17 9:11 AM, Sean Mullan wrote: On 3/31/17 9:08 AM, Weijun Wang wrote: Can we just move the code you just added into the public API directly? Looks like it does not refere

Re: JDK-8016345 (DNSName does not accept names with leading numbers) will-not-fix? Why?

2017-03-31 Thread Thomas Lußnig
Hi, both errors have in common that there are about an change of allowed hostnames. But as for the second bug there is an big mistake. The underscore is allowed for SRV and CNAME but not for A records. For SRV records it is wide used in LDAP records for MS Domain System (PDC). But the Subject

Re: [10] RFR: 8175029: StackOverflowError in X509CRL and X509Certificate.verify(PublicKey, Provider)

2017-03-31 Thread Sean Mullan
On 3/31/17 9:08 AM, Weijun Wang wrote: Can we just move the code you just added into the public API directly? Looks like it does not reference any internal classes. Good point, that should work! I'll try that and send out an updated webrev later. --Sean --Max On 03/31/2017 08:06 PM, Sean

Re: [10] RFR: 8175029: StackOverflowError in X509CRL and X509Certificate.verify(PublicKey, Provider)

2017-03-31 Thread Weijun Wang
Can we just move the code you just added into the public API directly? Looks like it does not reference any internal classes. --Max On 03/31/2017 08:06 PM, Sean Mullan wrote: Please review this fix for a StackOverflowError caused by the default implementation of verify(PublicKey, Provider). b

[10] RFR: 8175029: StackOverflowError in X509CRL and X509Certificate.verify(PublicKey, Provider)

2017-03-31 Thread Sean Mullan
Please review this fix for a StackOverflowError caused by the default implementation of verify(PublicKey, Provider). bug: https://bugs.openjdk.java.net/browse/JDK-8175029 webrev: http://cr.openjdk.java.net/~mullan/webrevs/8175029/webrev.00/ Thanks, Sean