Looks better; thanks Jon,
-Joe
On 4/26/2017 6:49 PM, Jonathan Gibbons wrote:
Updated webrev to address Joe's suggestion to try harder to use
{@code} as a substitute for .
http://cr.openjdk.java.net/~jjg/8179370/webrev.01
The modified sed script has a new first line:
s|\([^&<>]*\)|{@code \1
Updated webrev to address Joe's suggestion to try harder to use {@code}
as a substitute for .
http://cr.openjdk.java.net/~jjg/8179370/webrev.01
The modified sed script has a new first line:
s|\([^&<>]*\)|{@code \1}|g
s|||g
s|||g
s|<\\/tt>|<\\/code>|g
s|\(]*\)>\([^<]*\)|\1 style="text-align:cen
Looks okay.
Mandy
> On Apr 26, 2017, at 5:50 PM, Jonathan Gibbons
> wrote:
>
> Please review these mostly simple changes to replace HTML tags which are not
> valid in HTML 5 in public doc comments in java.base.
>
> As with the previous changes, the changes were done mechanically, using the
>
Joe,
Yes, there are occurrences here that require instead of {@code},
because of the presence of HTML entities. It's about 50/50.
I'd prefer to stay with mechanical updates as much as possible for these
bulk updates, as compared to manual updates, but I may be able to
improve the sed script
Hi Jon,
I'd prefer if the "foo" were replaced with "{@code tt}" rather
than "foo"- none of the tricky cases which preclude use of
{@code } use seem to be present here - but will approve the changeset in
its current form too.
Cheers,
-Joe
On 4/26/2017 5:50 PM, Jonathan Gibbons wrote:
Please
Please review these mostly simple changes to replace HTML tags which are
not valid in HTML 5 in public doc comments in java.base.
As with the previous changes, the changes were done mechanically, using
the following sed script:
s|||g
s|||g
s|<\\/tt>|<\\/code>|g
s|\(]*\)>\([^<]*\)|\1 style="te
On 4/26/17 1:52 PM, Steven Davidovitz wrote:
Thanks! I'm working on the OCA right now, I made a mistake when I
submitted it before so I'll follow up when it's done.
Anything else I need to do? Could this also be backported to version 8?
We are already at RDP2 [1] for JDK 9. Only P1 and P2 bugs
Thanks! I'm working on the OCA right now, I made a mistake when I submitted
it before so I'll follow up when it's done.
Anything else I need to do? Could this also be backported to version 8?
On Tue, Apr 25, 2017 at 7:05 AM, Sean Mullan wrote:
> Hi Steven,
>
> Thanks, I filed an issue on your b
