RE: RFR 8181461: sun/security/krb5/auto/KdcPolicy.java fails with java.lang.Exception: Does not match

2017-06-05 Thread Sibabrata Sahoo
Change looks fine to me. But I am not the reviewer yet. Thanks, Siba -Original Message- From: Weijun Wang Sent: Tuesday, June 06, 2017 11:23 AM To: Security Dev OpenJDK Cc: Gustavo Galimberti; Sibabrata Sahoo Subject: RFR 8181461: sun/security/krb5/auto/KdcPolicy.java fails with java.la

RFR 8181461: sun/security/krb5/auto/KdcPolicy.java fails with java.lang.Exception: Does not match

2017-06-05 Thread Weijun Wang
Please take a review on this change: http://cr.openjdk.java.net/~weijun/8181461/webrev.00/ This is a test bug and the fix is simply: // 1. Default policy is tryLast writeConf(1, 3000, p1, p3); -test("a3000c3000c3000|a3000c3000-|a3000c3000c3000-"); +test

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

2017-06-05 Thread Igor Ignatyev
just out of curiosity I have removed @build for all jdk.testlibary classes as well and run :tier1, it took approximately the same amount of time[1], the breakdown[2] shows that we spend 70 seconds more on build actions, which is not that big comparing to total execution time. -- Igor [1] real

Code Review Request, JDK-8178728 Check the AlgorithmParameters in algorithm constraints

2017-06-05 Thread Xuelei Fan
Hi, Please review the JDK 10 update: http://cr.openjdk.java.net/~xuelei/8178728/webrev.00/ This update extends the DisabledAlgorithmConstraints implementation by checking the AlgorithmParameters, which is ignored at present. Thanks, Xuelei

RFR JDK-8179614: Test for jarsigner on verifying jars that are signed and timestamped by other JDK releases

2017-06-05 Thread sha . jiang
Hi, Please review this manual test for checking if a jar, which is signed and timestamped by a JDK build, could be verified by other JDK builds. It also can be used to check if the default timestamp digest algorithm on signing is SHA-256. For more details, please look through the test summary.