Stricter Public Key checking corrupts JKS

2017-06-09 Thread Bernd
I noticed there is a bug (8177657,etc) about stricter DER checking on JDK Certificate code. I have an JKS Keystore which no longer can be opened because of that. I understand that the strict parsing has to stay for public keys, however I wonder if anything can be done about loading the other keys

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

2017-06-09 Thread Ioi Lam
On 6/2/17 8:44 AM, Ioi Lam wrote: On 6/2/17 6:40 AM, Chris Hegarty wrote: On 02/06/17 00:14, Ioi Lam wrote: ... The gem is hidden in the compile.0.jta file. It contains something like: -sourcepath :/jdk/foobar/test/lib: So if my test refers to a class under /test/lib, such as jdk

Re: JPMS Access Checks, Verification and the Security Manager

2017-06-09 Thread Alex Buckley
On 5/24/2017 12:13 AM, Volker Simonis wrote: OK, so from what you say I understand that the verification errors I see with the Security Manager enabled are an implementation detail of HotSpot (because verification uses the same class loading mechanism like the runtime) which is not required but s

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

2017-06-09 Thread Ioi Lam
I agree with what Daniel said. Even without explicit @build tags (as in the reproducer in CODETOOLS-790198), if you use something like @run main RedefineClassHelper that would cause an implicit invocation of "@build test/lib", because RedefineClassHelper.java is part of test/lib So it's

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

2017-06-09 Thread Ioi Lam
On 6/2/17 6:40 AM, Chris Hegarty wrote: On 02/06/17 00:14, Ioi Lam wrote: ... The gem is hidden in the compile.0.jta file. It contains something like: -sourcepath :/jdk/foobar/test/lib: So if my test refers to a class under /test/lib, such as jdk.test.lib.process.ProcessTools, javac w

Re: RSASSA_PSS (for Certificates)

2017-06-09 Thread Bradford Wetmore
Don't know if you've noticed, but JDK-8146293 is marked as "In Progress". The companion JSSE bug is: JDK-8166595. Brad On 6/9/2017 2:19 AM, Bernd Eckenfels wrote: Hello, Are there any plans to support RSA PSS as a Signature algorithm? https://bugs.openjdk.java.net/browse/JDK-8146293 In t

Re: Code review request: JDK-8046295 - Support Trusted CA Indication extension

2017-06-09 Thread Xuelei Fan
I'm OK to use SSLParameters. Thank you very much for considering a new design. Xuelei On 6/9/2017 1:10 PM, Martin Balao wrote: Hi Xuelei, I didn't notice that some of the SSLSocket contructors did not establish the connection, so SSLParameters can be effective for Trusted CA Indication. Th

Re: Code review request: JDK-8046295 - Support Trusted CA Indication extension

2017-06-09 Thread Martin Balao
Hi Xuelei, I didn't notice that some of the SSLSocket contructors did not establish the connection, so SSLParameters can be effective for Trusted CA Indication. This was an invalid argument on my side, sorry. As for the configuration to enable the extension, it's probably not necessary on the Ser

Re: RFR JDK-8179614: Test for jarsigner on verifying jars that are signed and timestamped by other JDK releases

2017-06-09 Thread Weijun Wang
On 06/09/2017 09:25 PM, [email protected] wrote: Hi Max, On 09/06/2017 20:05, Weijun Wang wrote: The test can be more friendly with default values. For example, in createCertificates(), you can generate certs that use default sigalg and keysize (i.e. without specifying -siglag and -keysi

Re: RFR JDK-8179614: Test for jarsigner on verifying jars that are signed and timestamped by other JDK releases

2017-06-09 Thread sha . jiang
Hi Max, On 09/06/2017 20:05, Weijun Wang wrote: The test can be more friendly with default values. For example, in createCertificates(), you can generate certs that use default sigalg and keysize (i.e. without specifying -siglag and -keysize), and give them aliases with "default" or "null" in

Re: RFR JDK-8179614: Test for jarsigner on verifying jars that are signed and timestamped by other JDK releases

2017-06-09 Thread Weijun Wang
The test can be more friendly with default values. For example, in createCertificates(), you can generate certs that use default sigalg and keysize (i.e. without specifying -siglag and -keysize), and give them aliases with "default" or "null" inside. And in jar signing when signing with one -

RSASSA_PSS (for Certificates)

2017-06-09 Thread Bernd Eckenfels
Hello, Are there any plans to support RSA PSS as a Signature algorithm? https://bugs.openjdk.java.net/browse/JDK-8146293 In the german energy market RSA PSS is used for signing messages, and authorities demand to use it also for certificate signatures (RFC 4055) starting with 2018. This is some

Re: RFR JDK-8179614: Test for jarsigner on verifying jars that are signed and timestamped by other JDK releases

2017-06-09 Thread sha . jiang
Hi Sean and Max, Thanks for your comments. Please review the updated webrev: http://cr.openjdk.java.net/~jjiang/8179614/webrev.01/ The test has been modified significantly. The main points are: 1. Adds cases on EC. Now the test supports key algorithms RSA, DSA and EC. 2. Adds cases on SHA-512.