Re: JCA design for RFC 7748

2017-08-18 Thread Michael StJohns
On 8/18/2017 3:26 PM, Adam Petcher wrote: On 8/17/2017 1:44 PM, Michael StJohns wrote: See inline. On 8/17/2017 11:19 AM, Adam Petcher wrote: Specifically, these standards have properties related to byte arrays like: "The Curve25519 function was carefully designed to allow all 32-byte stri

Re: JCA design for RFC 7748

2017-08-18 Thread Adam Petcher
On 8/17/2017 1:44 PM, Michael StJohns wrote: See inline. On 8/17/2017 11:19 AM, Adam Petcher wrote: Specifically, these standards have properties related to byte arrays like: "The Curve25519 function was carefully designed to allow all 32-byte strings as Diffie-Hellman public keys."[1] Th

Re: JCA design for RFC 7748

2017-08-18 Thread Michael StJohns
On 8/17/2017 7:01 PM, Xuelei Fan wrote: On 8/17/2017 11:35 AM, Michael StJohns wrote: On 8/17/2017 1:28 PM, Xuelei Fan wrote: This is the same for ANY current publicly known curve - different providers may implement all some or none of them. So extending this model for the curve25519 stuff is

Re: RFR: JDK-8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-18 Thread Sean Mullan
On 8/18/17 8:31 AM, Jan Lahoda wrote: For the langtools change, I think we shouldn't remove the entries from the include.list. This list defines which packages/classes should and should not be available when compiling for previous versions of the platform using --release. The removed entries ar

Re: RFR: JDK-8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-18 Thread Sean Mullan
On 8/17/17 8:16 PM, Weijun Wang wrote: Hi Sean Change looks fine. And I found another 4 references in comments in jdk/src/java.base/share/classes/javax/security/auth/Policy.java. Good catch. I changed SolarisPrincipal and SolarisNumericUserPrincipal to UnixPrincipal and UnixNumericUserPrinc

RFR: 8170157, 8170245: Enable unlimited cryptographic policy by default in OracleJDK

2017-08-18 Thread Seán Coffey
Looking to backport 8170157 to jdk8u-dev. The 8170245 test bug also gets pulled in for this port since some tests need cleaning up to deal with unlimited crypto environment. webrev : http://cr.openjdk.java.net/~coffeys/webrev.8170157.8u.01/webrev/index.html -- Regards, Sean.

Re: RFR: JDK-8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-18 Thread Jan Lahoda
For the langtools change, I think we shouldn't remove the entries from the include.list. This list defines which packages/classes should and should not be available when compiling for previous versions of the platform using --release. The removed entries are exclude entries, so if removed, it w

Re: RFR: JDK-8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-18 Thread Vincent Ryan
Your changes look fine to me. Thanks. > On 17 Aug 2017, at 20:08, Sean Mullan wrote: > > Please review this JDK 10 change to remove the deprecated classes in > com.sun.security.auth.** that have been previously marked with > forRemoval=true in JDK 9. > > webrev: http://cr.openjdk.java.net/~m