Re: RFR 8186576: KerberosTicket does not properly handle renewable tickets at the end of their lifetime

> On Aug 25, 2017, at 7:46 AM, Xuelei Fan wrote: > > On 8/24/2017 4:44 PM, Weijun Wang wrote: >>> On Aug 25, 2017, at 6:27 AM, Xuelei Fan wrote: >>> >>> javax/security/auth/kerberos/KerberosTicket.java >>> >>> if (getRenewTill() == null) { >>>

Re: RFR 8186576: KerberosTicket does not properly handle renewable tickets at the end of their lifetime

On 8/24/2017 4:44 PM, Weijun Wang wrote: On Aug 25, 2017, at 6:27 AM, Xuelei Fan wrote: javax/security/auth/kerberos/KerberosTicket.java if (getRenewTill() == null) { // The current ticket's lifetime is greater than renew_until. // No n

Re: RFR 8186576: KerberosTicket does not properly handle renewable tickets at the end of their lifetime

> On Aug 25, 2017, at 6:27 AM, Xuelei Fan wrote: > > javax/security/auth/kerberos/KerberosTicket.java > > if (getRenewTill() == null) { >// The current ticket's lifetime is greater than renew_until. >// No need to refresh. >return; > }

Re: RFR 8186576: KerberosTicket does not properly handle renewable tickets at the end of their lifetime

javax/security/auth/kerberos/KerberosTicket.java if (getRenewTill() == null) { // The current ticket's lifetime is greater than renew_until. // No need to refresh. return; } The comment is confusing to me. Per the getRenewTill() specif

Re: [10] RFR 8173181: Empty string alias in KeyStore throws StringIndexOutOfBoundsException for getEntry()

> On Aug 24, 2017, at 10:53 PM, Vincent Ryan wrote: > > >> On 24 Aug 2017, at 15:50, Weijun Wang wrote: >> >> 1. Maybe just check length > 1? > > Yes. I’ll make the change. > >> >> 2. The test's @summary seems unrelated. > > An empty alias is supported in JKS. Got it. --Max > > >> >

Re: [10] RFR 8173181: Empty string alias in KeyStore throws StringIndexOutOfBoundsException for getEntry()

> On 24 Aug 2017, at 15:50, Weijun Wang wrote: > > 1. Maybe just check length > 1? Yes. I’ll make the change. > > 2. The test's @summary seems unrelated. An empty alias is supported in JKS. > > --Max > >> On Aug 24, 2017, at 10:27 PM, Vincent Ryan wrote: >> >> Please review this fix to

Re: [10] RFR 8173181: Empty string alias in KeyStore throws StringIndexOutOfBoundsException for getEntry()

1. Maybe just check length > 1? 2. The test's @summary seems unrelated. --Max > On Aug 24, 2017, at 10:27 PM, Vincent Ryan wrote: > > Please review this fix to correct support for an empty string alias in PKCS12 > keystores. > Thanks. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8173181

[10] RFR 8173181: Empty string alias in KeyStore throws StringIndexOutOfBoundsException for getEntry()

Please review this fix to correct support for an empty string alias in PKCS12 keystores. Thanks. Bug: https://bugs.openjdk.java.net/browse/JDK-8173181 Webrev: http://cr.openjdk.java.net/~vinnie/8173181/webrev.00/

RFR 8186576: KerberosTicket does not properly handle renewable tickets at the end of their lifetime

Please review the fix at http://cr.openjdk.java.net/~weijun/8186576/webrev.00 This is a MIT/krb5 bug [1], but we will accept it anyway. Also, renew such a ticket is now a no-op because the lifetime will not be extended anyway. New test included. Thanks Max [1] http://mailman.mit.edu/piperm