Re: Code Review Request: JDK-6491070 (Support for RFC 5929-Channel Bindings)

2017-08-31 Thread Xuelei Fan
The failure-and-retry mechanism could a nightmare for some applications. Please think more how could we avoid it. If need more APIs, what the update may looks like and how complicated it could be? If required, Bernd's proposal can be extended a little bit to support operations other than lis

Re: [10] XXS RFR 8187023: Cannot read pkcs11 config file in UTF-16 environment

2017-08-31 Thread Anthony Scarpino
On 08/31/2017 02:19 PM, Ivan Gerasimov wrote: On 8/31/17 1:44 PM, Anthony Scarpino wrote: On 08/31/2017 01:10 PM, Ivan Gerasimov wrote: Hello! Currently, when reading the pkcs11 config file, the default encoding is assumed. This causes errors when the encoding is set to UTF-16. Would you

Re: [10] XXS RFR 8187023: Cannot read pkcs11 config file in UTF-16 environment

2017-08-31 Thread Ivan Gerasimov
On 8/31/17 1:44 PM, Anthony Scarpino wrote: On 08/31/2017 01:10 PM, Ivan Gerasimov wrote: Hello! Currently, when reading the pkcs11 config file, the default encoding is assumed. This causes errors when the encoding is set to UTF-16. Would you please help review the trivial fix? Bug: http

Re: [10] XXS RFR 8187023: Cannot read pkcs11 config file in UTF-16 environment

2017-08-31 Thread Anthony Scarpino
On 08/31/2017 01:10 PM, Ivan Gerasimov wrote: Hello! Currently, when reading the pkcs11 config file, the default encoding is assumed. This causes errors when the encoding is set to UTF-16. Would you please help review the trivial fix? Bug: https://bugs.openjdk.java.net/browse/JDK-8187023 W

[10] XXS RFR 8187023: Cannot read pkcs11 config file in UTF-16 environment

2017-08-31 Thread Ivan Gerasimov
Hello! Currently, when reading the pkcs11 config file, the default encoding is assumed. This causes errors when the encoding is set to UTF-16. Would you please help review the trivial fix? Bug: https://bugs.openjdk.java.net/browse/JDK-8187023 Webrev: http://cr.openjdk.java.net/~igerasim/818

Re: Code Review Request: JDK-6491070 (Support for RFC 5929-Channel Bindings)

2017-08-31 Thread Martin Balao
Hi, The material is already cached in the handshaker if secure renegotiation is enabled. However, I agree with you that we are going to cache the value even when secure renegotiation is not enabled, thus, wasting roughly 12 bytes (as bytes for an empty array are already consumed). In fact, the exa

Re: RFR 8186931: jdk.security.jarsigner package is missing package summary

2017-08-31 Thread Sean Mullan
On 8/31/17 4:49 AM, Weijun Wang wrote: /** * This package contains the {@link jdk.security.jarsigner.JarSigner} API, * which backs the signing function of the {@code jarsigner} tool. */ I think you should say something about that this API can be used to sign JAR files. The fact that it is als

RFR 8186931: jdk.security.jarsigner package is missing package summary

2017-08-31 Thread Weijun Wang
Please take a review at this new package.java file. /* * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU Gene