Small update on http://cr.openjdk.java.net/~weijun/8186884/webrev.02. All files
belong to a single Proc now have the same prefix so they appear together in
file list.
Thanks
Max
> On Sep 7, 2017, at 8:39 PM, Weijun Wang wrote:
>
> Updated at
>
>
> On Sep 6, 2017, at 5:24 PM, Alan Bateman wrote:
>
>
>
> On 06/09/2017 05:17, Weijun Wang wrote:
>> Hi All
>>
>> Please review the change, which spans to root, jdk and langtools repos.
>>
>> http://cr.openjdk.java.net/~weijun/8148371/
>>
>> I've searched for the
According to https://tools.ietf.org/html/rfc4120#section-3.1.3:
A "newer" enctype is any enctype first officially
specified concurrently with or subsequent to the issue of this RFC.
The enctypes DES, 3DES, or RC4 and any defined in [RFC1510] are not
"newer" enctypes.
Looks fine to me.
A minor comment about the method name "isNew", i'm not very sure what does it
means. I would add comments about what the "new" refers to.
Xuelei
> On Aug 28, 2017, at 11:12 PM, Weijun Wang wrote:
>
> Please review the fix at
>
>
Ping again.
> On Aug 28, 2017, at 11:12 PM, Weijun Wang wrote:
>
> Please review the fix at
>
> http://cr.openjdk.java.net/~weijun/8186831/webrev.00/
>
> This is an old bug that is about to bite us soon.
>
> Thanks
> Max
>
Looks good.
--Sean
On 9/5/17 7:16 PM, Weijun Wang wrote:
The package info for com.sun.security.jgss in jdk.security.jgss is also
missing. The updated change looks like this (I omit the copyright header):
src/jdk.jartool/share/classes/jdk/security/jarsigner/package-info.java:
+/**
+ * This
On 9/7/17 10:25 AM, Seán Coffey wrote:
Looks good to me Ivan.
Thanks Seán!
With kind regards,
Ivan
regards,
Sean.
On 23/08/2017 21:54, Ivan Gerasimov wrote:
Hello!
An auxiliary class EqualByteArray implements hashCode() in a way that
small changes to the content do not change the hash
Looks good to me Ivan.
regards,
Sean.
On 23/08/2017 21:54, Ivan Gerasimov wrote:
Hello!
An auxiliary class EqualByteArray implements hashCode() in a way that
small changes to the content do not change the hash value.
It is proposed to reuse Arrays.hashCode(byte[]) for the hash code
Updated at
http://cr.openjdk.java.net/~weijun/8186884/webrev.01/
Now the libraries can be more freely combined, so you can test interop between
one native library and another one:
jtreg -Dnative.krb5.libs=j=,n=,m=lib1.so,h=lib2.so BasicProc.java
More comments inline below.
> On Sep 7,
Hi Artem,
On 07/09/2017 16:28, Artem Smotrakov wrote:
In case of SNI, SSLParemeters.setServerNames() method (and others
related to SNI) was introduced in 8. I don't think the code which use
this method can be compiled with 6 and 7.
All of Java source are compiled by a JDK 10 build, which is
In case of SNI, SSLParemeters.setServerNames() method (and others
related to SNI) was introduced in 8. I don't think the code which use
this method can be compiled with 6 and 7.
But if you want to test SNI with 8+, you need to call them.
Hi John,
Please see inline.
On 09/07/2017 10:52 AM, sha.ji...@oracle.com wrote:
Then you can build a Cartesian product of all parameters. Client and
sever should take parameters, and say if they support all of the or
not (for example, JDK 6 might not support all features that JDK 9
does).
Hi Artem,
Thanks for your comments!
Please see inline.
On 07/09/2017 14:32, Artem Smotrakov wrote:
Hi John,
Thanks for starting working on this. I believe this tool is going to
be very helpful.
Let me skip some coding comments for a while, I have a couple of
comments about the design. The
Hi Max,
In general, looks fine to me. Below are a couple of comments you might
want to address.
1. BasicProc.java, it might be better to use named constants for
parameters for once() method. That would make it easier to understand
what each particular onse() call does
+
Hi John,
Thanks for starting working on this. I believe this tool is going to be
very helpful.
Let me skip some coding comments for a while, I have a couple of
comments about the design. The main idea is that it should cover as many
cases as it can. Even if it might look a bit redundant, I
15 matches
Mail list logo