Re: RFR 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5

2018-01-09 Thread Weijun Wang
> On Jan 10, 2018, at 12:22 AM, Sean Mullan wrote: > > On 12/19/17 8:39 PM, Weijun Wang wrote: >>> On Dec 20, 2017, at 5:02 AM, Sean Mullan wrote: >>> >>> On 12/19/17 10:52 AM, Weijun Wang wrote: > * AesSha2DkCrypto.java > > - why does stringToKey(char[] password, String salt, by

Re: RFR 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5

2018-01-09 Thread Sean Mullan
On 12/19/17 8:39 PM, Weijun Wang wrote: On Dec 20, 2017, at 5:02 AM, Sean Mullan wrote: On 12/19/17 10:52 AM, Weijun Wang wrote: * AesSha2DkCrypto.java - why does stringToKey(char[] password, String salt, byte[] s2kparams) swallow exceptions but stringToKey(char[] secret, byte[] salt, byt

Re: RFR JDK-8194257: javax/net/ssl/compatibility/Compatibility.java should be updated for JDK 6 after JDK-8174748

2018-01-09 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 1/8/2018 7:02 PM, sha.ji...@oracle.com wrote: Hi, After JDK-8174748, the AES_256 cipher suites are enabled by default for JDK 6, so this test has to mark those cipher suites are supported by JDK 6. In addition, some AES_128 cipher suites also should be marke