Re: RFR 8195119: Fine-tune output text in keytool

2018-01-16 Thread Sean Mullan
Looks good. --Sean On 1/15/18 8:57 PM, Weijun Wang wrote: The translation team suggested a small text change: diff --git a/src/java.base/share/classes/sun/security/tools/keytool/Resources.java b/src/java.base/share/classes/sun/security/tools/keytool/Resources.java --- a/src/java.base/share/c

Re: RFR 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5

2018-01-16 Thread Sean Mullan
On 1/14/18 9:12 PM, Weijun Wang wrote: Hi Sean Do you have other comments on the webrev [1]? No. I've also updated the CSR [2]. Ok, thanks. --Sean Thanks Max [1] http://cr.openjdk.java.net/~weijun/8014628/webrev.00/ [2] https://bugs.openjdk.java.net/browse/JDK-8193851 On Jan 13, 20

Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC

2018-01-16 Thread Adam Petcher
Great! I took a look at the patch, and I have some comments, the first of which probably needs to be addressed before I can test the change: 1) Is this patch against the http://hg.openjdk.java.net/jdk/jdk repository? I suspect it isn't because some of the paths are different than what I expect

contribute to the OpenJDK security group

2018-01-16 Thread Leo Grove
Hello Everyone, I'd like to introduce myself. I'm Leo Grove, founder of SSL.com and also Java Certified Programmer ('98). Although I'm not so much into coding these days, I'm always looking for ways to contribute to internet security and the public WebPKI. We do have some very sharp java deve

Re: RFR: 8194960: Add a test for trust manager and cacerts keystore sanity

2018-01-16 Thread Martin Buchholz
On Mon, Jan 15, 2018 at 7:47 PM, Weijun Wang wrote: > Hi Martin > > This is fine as a test. I don't know which is the recommended call, but > "keytool -list -cacerts" also does it. > > The test uses an API that adds a layer of abstraction, not exposing the presence of a cacerts file. > BTW, usu