Re: JDK 11 RFR of JDK-8196414: Update ProviderVersionCheck.java to pass on updated JDK versions

2018-01-30 Thread Sean Mullan
On 1/30/18 1:19 PM, joe darcy wrote: Hi Sean, On 1/30/2018 10:03 AM, Sean Mullan wrote: Does Runtime.version().feature() return the same value as the "java.specification.version" property? (see sun.security.util.SecurityConstants.PROVIDER_VER). That is the value that the JDK security provide

Re: JDK 11 RFR of JDK-8196414: Update ProviderVersionCheck.java to pass on updated JDK versions

2018-01-30 Thread joe darcy
Hi Sean, On 1/30/2018 10:03 AM, Sean Mullan wrote: Does Runtime.version().feature() return the same value as the "java.specification.version" property? (see sun.security.util.SecurityConstants.PROVIDER_VER). That is the value that the JDK security providers use as their version. If not, this

Re: JDK 11 RFR of JDK-8196414: Update ProviderVersionCheck.java to pass on updated JDK versions

2018-01-30 Thread Sean Mullan
Does Runtime.version().feature() return the same value as the "java.specification.version" property? (see sun.security.util.SecurityConstants.PROVIDER_VER). That is the value that the JDK security providers use as their version. If not, this test may fail when we bump up the version to 11 and

JDK 11 RFR of JDK-8196414: Update ProviderVersionCheck.java to pass on updated JDK versions

2018-01-30 Thread joe darcy
Hello, The test     java/security/Provider/ProviderVersionCheck.java has a version-check that is hard coded; therefore, it has to be updated with each major JDK update. If the test made its check based on the runtime version, no explicit update would be needed. Please review the patch below

Re: RFR 8181594: Efficient and constant-time modular arithmetic

2018-01-30 Thread Adam Petcher
+core-libs-dev On 1/26/2018 4:06 PM, Adam Petcher wrote: JBS: https://bugs.openjdk.java.net/browse/JDK-8181594 Webrev: http://cr.openjdk.java.net/~apetcher/8181594/webrev.00/ This is a code review for the field arithmetic that will be used in implementations of X25519/X448 key agreement, the

PKCS#11 provider issues with min and max size

2018-01-30 Thread Tomas Gustavsson
Hi, At some revision in the PKCS#11 provider there was introduced checking of C_GetMechanismInfo min and max sizes. This has turned out to be a bit fragile. Let me give two real world examples: 1. Amazon Cloud HSM report minSize and maxSize for EC keys to 0. The Java PKCS#11 provider will happi