Re: RFR 8199198: Remove unused functions in jdk.crypto.mscapi native code

Hello Max, Your change looks fine to me. Thanks. > On 7 Mar 2018, at 02:19, Weijun Wang wrote: > > Please take a review at > > http://cr.openjdk.java.net/~weijun/8199198/webrev.00 > > I just removed the 3 unused functions. They were there from the beginning > (2005) but had never existed i

Re: RFR 8193262: JNI array not released in libsunmscapi convertToLittleEndian

Looks good to me, but you need to update the copyright date. Also the bug will need at “noreg” label Tony > On Mar 7, 2018, at 8:15 PM, Weijun Wang wrote: > > Ping again. > >> On Feb 24, 2018, at 10:49 PM, Weijun Wang wrote: >> >> Please take a review at >> >> http://cr.openjdk.java.n

Re: RFR 8193262: JNI array not released in libsunmscapi convertToLittleEndian

Ping again. > On Feb 24, 2018, at 10:49 PM, Weijun Wang wrote: > > Please take a review at > > http://cr.openjdk.java.net/~weijun/8193262/webrev.00/ > > Noreg-hard. I modified my own JDK a little to directly call > convertToLittleEndian() using bad input and I can see my debug line before