Re: JEP 332: Transport Layer Security (TLS) 1.3

2018-04-04 Thread Sean Mullan
On 3/30/18 12:48 PM, David Lloyd wrote: Is it possible that this could make Java 11, or is that a long shot? We cannot say that it will make JDK 11 at this time. Also, at this stage in the JEP 2.0 Process, a Candidate means that it "is merely an idea worthy of consideration by JDK Release

Re: RFR 8190333: sun/security/ssl/X509KeyManager/PreferredKey.java failed with "Failed to get the preferable key aliases"

2018-04-04 Thread Sean Mullan
I think you should use a 2048-bit DSA key instead of 1024-bit. Otherwise looks fine. --Sean On 4/3/18 4:12 PM, Amanda Jiang wrote: Hi All, The changeset below updates an expired alias in keystore. Please help to review it. Bug: https://bugs.openjdk.java.net/browse/JDK-8190333 Webrev:

Re: RFR 8200468: Port the native GSS-API bridge to Windows

2018-04-04 Thread Magnus Ihse Bursie
On 2018-04-04 10:06, Weijun Wang wrote: On Apr 4, 2018, at 3:59 PM, Magnus Ihse Bursie wrote: Hi Max, On 2018-04-04 04:19, Weijun Wang wrote: Hi All Please take a review at http://cr.openjdk.java.net/~weijun/8200468/webrev.00/ The indentation in

RFR 8196540: [Testbug] java/security/AccessController/DoPrivAccompliceTest.java doesn't handle unrelated warnings

2018-04-04 Thread bhanu . prakash . gopularam
Hi All, Please review fix for following issue: JBS bug: https://bugs.openjdk.java.net/browse/JDK-8196540 webrev link: http://cr.openjdk.java.net/~bgopularam/8196540/security/webrev.00/ I have added utility method parsing the stderr output and ignore any VM warnings. Thanks, Bhanu

Re: RFR 8200468: Port the native GSS-API bridge to Windows

2018-04-04 Thread Weijun Wang
I've updated the patch in its original URL. Please confirm it's correct now. Thanks Max > On Apr 4, 2018, at 4:06 PM, Weijun Wang wrote: > > > >> On Apr 4, 2018, at 3:59 PM, Magnus Ihse Bursie >> wrote: >> >> Hi Max, >> >> On

Re: RFR 8200468: Port the native GSS-API bridge to Windows

2018-04-04 Thread Magnus Ihse Bursie
Hi Max, On 2018-04-04 04:19, Weijun Wang wrote: Hi All Please take a review at http://cr.openjdk.java.net/~weijun/8200468/webrev.00/ The indentation in Lib-java.security.jgss.gmk has gone wrong. The lines in the "$(eval $(call SetupJdkLibrary" stanza should still be indented four