Re: RFR[11] JDK-8146293 "Add Support for RSA-PSS Signature Algorithm as in PKCS#1 v2.2"

2018-04-16 Thread Sean Mullan
On 4/13/18 3:25 PM, Bradford Wetmore wrote: SunRsaSignEntries.java -- 145:  Where did you come up with this convention for your aliases?     SHA1withRSA-PSS I see Bouncy Castle[1] and Android[2] are both using:     SHA*withRSA/PSS     RSASSA-PSS (name from PKCS#1) [1]

Re: RFR 8144806: sun/security/tools/keytool/standard.sh fails intermittently at deleting x.jks

2018-04-16 Thread Weijun Wang
The change in KeyToolTest.java looks fine. You might also need to update autotest.sh in the same directory. --Max > On Apr 16, 2018, at 4:44 PM, bhanu.prakash.gopula...@oracle.com wrote: > > Hi All, > > Please review fix for following issue: > > JBS bug:

RE: RFR: 8200219: Develop new tests for using new elliptic curves: curve25519 and curve448

2018-04-16 Thread Sibabrata Sahoo
Hi Sean/Adam, Please review the updated patch, Webrev: http://cr.openjdk.java.net/~ssahoo/8184359/webrev.02/ Now there is only 1 Test file in the deleted list which has duplicate code. Due to that I have pointed the older JBS bug ID JDK-4936763 in KeyAgreementTest.java and linked the same to

RFR 8144806: sun/security/tools/keytool/standard.sh fails intermittently at deleting x.jks

2018-04-16 Thread bhanu . prakash . gopularam
Hi All, Please review fix for following issue: JBS bug: https://bugs.openjdk.java.net/browse/JDK-8144806 Webrev: http://cr.openjdk.java.net/~bgopularam/bhanu/8144806/webrev.00/ The patch fixes intermittent test failure. The fix uses deleteFileIfExistsWithRetry(..) from test library class